fix(substack): update selectors for Substack DOM redesign (fixes #621)#624
Merged
jackwener merged 2 commits intojackwener:mainfrom Mar 31, 2026
Merged
Conversation
…wener#621) Substack replaced <article> elements with role="article" divs and a new SPA-based feed. The wait() selector 'article' no longer matches, causing 'Selector not found: article' on feed and publication commands. - loadSubstackFeed: use 'a[href*="/p/"]' (matches actual post links) - loadSubstackArchive: use '[role="article"]' (Substack's new ARIA roles) The evaluate() scraping logic inside both functions is unchanged since it already uses 'a' href pattern matching, not article tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Substack redesigned their HTML structure, replacing
<article>elements with<div role="article">wrapped in their new Pencraft design system. BothloadSubstackFeedandloadSubstackArchivewait forarticleselector which no longer exists, causing:Fix
Updated wait selectors in
src/clis/substack/utils.ts:loadSubstackFeed(homepage/browse):article→a[href*="/p/"]/p/path are the reliable indicator that content has loadedevaluate()scraping code already queriesloadSubstackArchive(publication /archive):article→[role="article"]<div role="article">for post previews on archive pagesThe
evaluate()data extraction logic inside both functions is unchanged — it already usesahref pattern matching, not article tags.Testing
npm test)Closes #621
🤖 This PR was authored by an AI agent. If you'd prefer not to receive AI-generated contributions, please let me know and I won't submit further PRs to this repo.