Open
Conversation
Addresses five security issues identified in code audit:
1. Daemon Bearer-Token Authentication
- Generate crypto.randomBytes(32) token at startup
- Write to ~/.opencli/daemon.token (mode 0o600)
- Require Authorization: Bearer <token> on all non-/ping endpoints
- Constant-time comparison prevents timing side-channels
- daemon-client.ts lazily reads & caches token; auto-refreshes on 401
- Token file deleted on daemon shutdown
2. Extension ID Pinning (optional hardening)
- New OPENCLI_EXTENSION_ID env var for strict WebSocket origin check
- Rejects any chrome-extension:// origin that doesn't match the pin
3. HttpOnly Cookie Warning + Redaction
- OPENCLI_VERBOSE=1 emits warning when httpOnly cookies are returned
- OPENCLI_REDACT_COOKIES=1 or getCookies({ redact: true }) replaces
httpOnly and sensitive-named cookie values with '[REDACTED]'
- New isSensitiveCookieName() / redactCookies() helpers in types.ts
4. CDP Endpoint Localhost Enforcement
- assertLocalhostEndpoint() blocks non-loopback OPENCLI_CDP_ENDPOINT
- Override with OPENCLI_CDP_ALLOW_REMOTE=1 for advanced use cases
5. Pipeline fetch credentials:"include" risk comment
- Documents CSRF risk and required URL trust requirement
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issue:
Type of Change
Checklist
Documentation (if adding/modifying an adapter)
docs/adapters/(if new adapter)docs/adapters/index.mdtable (if new adapter)docs/.vitepress/config.mts(if new adapter)README.md/README.zh-CN.mdwhen command discoverability changedCliErrorsubclasses instead of rawErrorScreenshots / Output