This repository was archived by the owner on Aug 17, 2020. It is now read-only.
Open
Conversation
Member
|
It would be nice to figure out why this is happening so often. |
Stebalien
reviewed
Sep 3, 2018
main.go
Outdated
| for r := 0; r < *retries; r++ { | ||
| var h host.Host | ||
| var d *dht.IpfsDHT | ||
| h, d, err = makeAndStartNode(ds, "/ip4/0.0.0.0/tcp/0", *relay, *retries) |
Member
There was a problem hiding this comment.
Does creating the node itself (not just bootstrapping) fail? That should never happen.
Member
Author
There was a problem hiding this comment.
Well, I haven't seen that happen, I guess erroring/panicking here is more correct
magik6k
force-pushed
the
feat/retries
branch
from
ca19d4b to
51f06c5
Compare
Stebalien
reviewed
Sep 3, 2018
Member
Stebalien
left a comment
Stebalien
left a comment
There was a problem hiding this comment.
LGTM but @whyrusleeping should definitely look at this.
Member
|
Alternatively, we should add more different bootstrappers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When starting many nodes, even with good networks, it tends to fail on one or two annoyingly often. This adds a way to workaround that.