Skip to content

Add Support for Nonmanifold Smooth Edges#223

Merged
zfergus merged 9 commits intomainfrom
nonmanifold-smooth-edges
Mar 15, 2026
Merged

Add Support for Nonmanifold Smooth Edges#223
zfergus merged 9 commits intomainfrom
nonmanifold-smooth-edges

Conversation

@zfergus
Copy link
Member

@zfergus zfergus commented Mar 14, 2026

Description

Refactor edge-to-faces mapping and generalize edge3 primitive to N-face neighbors

  • Change edges_to_faces from fixed-size matrix to vector of vectors
  • Update Edge3 to support arbitrary number of adjacent faces
  • Generalize smooth_edge3_term and derivatives for N-face neighbors
  • Increase N_EDGE_NEIGHBORS_3D from 4 to 6
  • Update Point3 and tests to use Eigen::MatrixX3d for tangent/neighbor arrays

Type of change

  • Enhancement (non-breaking change which improves existing functionality)

neighbors

- Change edges_to_faces from fixed-size matrix to vector of vectors
- Update Edge3 to support arbitrary number of adjacent faces
- Generalize smooth_edge3_term and derivatives for N-face neighbors
- Increase N_EDGE_NEIGHBORS_3D from 4 to 6
- Update Point3 and tests to use Eigen::MatrixX3d for tangent/neighbor
  arrays
@zfergus zfergus requested a review from Copilot March 14, 2026 17:19
@codecov
Copy link

codecov bot commented Mar 14, 2026

Codecov Report

❌ Patch coverage is 98.39744% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.75%. Comparing base (f313470) to head (73cac61).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ipc/smooth_contact/primitives/edge3.cpp 98.37% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
- Coverage   97.20%   95.75%   -1.46%     
==========================================
  Files         160      159       -1     
  Lines       24926    16434    -8492     
  Branches      899      913      +14     
==========================================
- Hits        24229    15736    -8493     
- Misses        697      698       +1     
Flag Coverage Δ
unittests 95.75% <98.39%> (-1.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 13 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@zfergus zfergus merged commit 9436b3f into main Mar 15, 2026
19 checks passed
@zfergus zfergus deleted the nonmanifold-smooth-edges branch March 15, 2026 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants