Add Support for Nonmanifold Smooth Edges#223
Merged
Conversation
neighbors - Change edges_to_faces from fixed-size matrix to vector of vectors - Update Edge3 to support arbitrary number of adjacent faces - Generalize smooth_edge3_term and derivatives for N-face neighbors - Increase N_EDGE_NEIGHBORS_3D from 4 to 6 - Update Point3 and tests to use Eigen::MatrixX3d for tangent/neighbor arrays
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #223 +/- ##
==========================================
- Coverage 97.20% 95.75% -1.46%
==========================================
Files 160 159 -1
Lines 24926 16434 -8492
Branches 899 913 +14
==========================================
- Hits 24229 15736 -8493
- Misses 697 698 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 13 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor edge-to-faces mapping and generalize edge3 primitive to N-face neighbors
Type of change