Skip to content

Clean up closest point autogen #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zfergus merged 2 commits into from
Mar 5, 2026
Merged

Clean up closest point autogen #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
453e658
Clean up closest point autogen
zfergus Mar 5, 2026
9458ef8
Apply suggestions from code review
zfergus Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/ipc/smooth_contact/distance/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
set(SOURCES
autogen.hpp
autogen.cpp
mollifier.cpp
mollifier.hpp
mollifier.tpp
Expand Down
3,595 changes: 0 additions & 3,595 deletions src/ipc/smooth_contact/distance/autogen.cpp
View file
Open in desktop

This file was deleted.

163 changes: 0 additions & 163 deletions src/ipc/smooth_contact/distance/autogen.hpp
View file
Open in desktop

This file was deleted.

11 changes: 2 additions & 9 deletions src/ipc/smooth_contact/distance/edge_edge.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
#include "edge_edge.hpp"

#include "autogen.hpp"

#include <ipc/tangent/closest_point.hpp>

#include <unsupported/Eigen/KroneckerProduct>
Expand Down Expand Up @@ -188,13 +186,8 @@ line_line_closest_point_pairs_hessian(
}

{
Eigen::Matrix<double, 12, 12> Ha, Hb;
autogen::edge_edge_closest_point_hessian_a(
ea0.x(), ea0.y(), ea0.z(), ea1.x(), ea1.y(), ea1.z(), eb0.x(),
eb0.y(), eb0.z(), eb1.x(), eb1.y(), eb1.z(), Ha.data());
autogen::edge_edge_closest_point_hessian_b(
ea0.x(), ea0.y(), ea0.z(), ea1.x(), ea1.y(), ea1.z(), eb0.x(),
eb0.y(), eb0.z(), eb1.x(), eb1.y(), eb1.z(), Hb.data());
const auto& [Ha, Hb] =
edge_edge_closest_point_hessian(ea0, ea1, eb0, eb1);

for (int d = 0; d < 3; d++) {
// wrt. uv
Expand Down
10 changes: 2 additions & 8 deletions src/ipc/smooth_contact/distance/point_face.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
#include "point_face.hpp"

#include "autogen.hpp"
#include "point_edge.hpp"

#include <ipc/tangent/closest_point.hpp>
Expand Down Expand Up @@ -43,13 +42,8 @@ point_plane_closest_point_direction_hessian(
const Eigen::Vector2d uv = point_triangle_closest_point(p, t0, t1, t2);
const Eigen::Matrix<double, 2, 12> jac =
point_triangle_closest_point_jacobian(p, t0, t1, t2);
std::array<Matrix12d, 2> H;
autogen::triangle_closest_point_hessian_0(
p(0), p(1), p(2), t0(0), t0(1), t0(2), t1(0), t1(1), t1(2), t2(0),
t2(1), t2(2), H[0].data());
autogen::triangle_closest_point_hessian_1(
p(0), p(1), p(2), t0(0), t0(1), t0(2), t1(0), t1(1), t1(2), t2(0),
t2(1), t2(2), H[1].data());
std::array<Matrix12d, 2> H =
point_triangle_closest_point_hessian(p, t0, t1, t2);

// compute derivatives of the closest point
const Eigen::Vector3d direc =
Expand Down
Loading