Skip to content

Comments

adding SCCOOS HABS R notebook#15

Closed
MathewBiddle wants to merge 208 commits intoioos:mainfrom
MathewBiddle:SCCOOS_HABs
Closed

adding SCCOOS HABS R notebook#15
MathewBiddle wants to merge 208 commits intoioos:mainfrom
MathewBiddle:SCCOOS_HABs

Conversation

@MathewBiddle
Copy link
Contributor

@MathewBiddle MathewBiddle commented Sep 3, 2021

adding sccoos HABs notebook

@review-notebook-app
Copy link

review-notebook-app bot commented Sep 3, 2021

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@MathewBiddle
Copy link
Contributor Author

MathewBiddle commented Sep 3, 2021

xref:

MathewBiddle and others added 24 commits September 3, 2021 12:17
@MathewBiddle
adding contributing guidance
4b7f356
@MathewBiddle
adding build instructions to README.md
8bf4bd6
@MathewBiddle
adding descriptive content
367b10e
@MathewBiddle
Merge pull request ioos#21 from MathewBiddle/update_readme
dff89a1 
adding build instructions to README.md
@MathewBiddle @ocefpaf
Update CONTRIBUTING.md
431ea06 
Co-authored-by: Filipe <ocefpaf@gmail.com>
@MathewBiddle
addressing comments
e987b41
@MathewBiddle
master -> main
25f0f93
@MathewBiddle
more master -> main
88b97a6
@MathewBiddle
Merge pull request ioos#20 from MathewBiddle/contribution
2213628 
adding contributing guidance
@ocefpaf
test page deployment and move build directory
493f445
@ocefpaf
fix build warnings
9a69e9c
@ocefpaf
update pre-commit
d898e3e
@ocefpaf
add if-clause to run only on master
3f3f330
@ocefpaf
Merge pull request ioos#10 from ocefpaf/GA-workaround
cf243c9 
GA workaround
@MathewBiddle
fixed searching for all platforms
f57bde3
@MathewBiddle
Merge branch 'main' into ncei_archive_update
8107263 
# Conflicts:
#	jupyterbook/content/code_gallery/data_access_notebooks/2017-06-12-NCEI_RA_archive_history.ipynb
@ocefpaf
Merge pull request ioos#11 from MathewBiddle/ncei_archive_update
84d6651 
fixing the NCEI RA archive notebook
@ocefpaf
update pre-commit
4d9074b
@ocefpaf
run pre-commit
8b7fcbe
@ocefpaf
fix minor typo and run cells in order
c98e18e
@ocefpaf
should probably track this notebook again
269d5ed
@ocefpaf
Merge pull request ioos#30 from ocefpaf/typo
e9486bd 
Typo
@ocefpaf
fix page deployment
77d2088
@ocefpaf
Merge pull request ioos#31 from ocefpaf/fix_page_deployment
8921be6 
fix page deployment
@MathewBiddle MathewBiddle marked this pull request as ready for review May 3, 2023 14:17
@MathewBiddle MathewBiddle requested a review from ocefpaf May 3, 2023 14:17
@MathewBiddle
Copy link
Contributor Author

MathewBiddle commented May 3, 2023

@ocefpaf this notebook is close. I can't figure out how to render the maps to be interactive on the code_lab website, however.

@ocefpaf
Copy link
Member

ocefpaf commented May 3, 2023

I can't figure out how to render the maps to be interactive on the code_lab website, however.

This is R, right? I'm not sure if there is anything special. Let me try...

@ocefpaf
Copy link
Member

ocefpaf commented May 3, 2023

@MathewBiddle this notebooks points to the old jupyterbook/content/Code Gallery/data_access_notebooks/DRAFT-SCCOOS-HABs.ipynb instead of the new jupyterbook/content/code_gallery/data_access_notebooks/DRAFT-SCCOOS-HABs.ipynb. We need to rebase it or, if that is easier, save the notebook, close the PR, and open a new one.

@MathewBiddle
Copy link
Contributor Author

MathewBiddle commented May 3, 2023

Oh right, this was developed a while ago! I'll work on fixing this.

@MathewBiddle
adding SCCOOS HABS R notebook
c365fc7
@MathewBiddle
Merge branch 'SCCOOS_HABs' of https://github.com/MathewBiddle/ioos_co…
a6cb1b2 
…de_lab into SCCOOS_HABs

# Conflicts:
#	jupyterbook/content/code_gallery/data_access_notebooks/DRAFT-SCCOOS-HABs.ipynb
@MathewBiddle
Copy link
Contributor Author

MathewBiddle commented May 3, 2023

I think I fixed it. 😢

@ocefpaf
Copy link
Member

ocefpaf commented May 3, 2023

Regarding the map, no need for the save+display. Just the m output is enough to render it on Jupyter:

Screenshot from 2023-05-03 12-20-54

but you may need to click on the Save Notebooks Widget State to make available for rendering in the final page.

Screenshot from 2023-05-03 12-21-54

@MathewBiddle
Copy link
Contributor Author

MathewBiddle commented May 3, 2023

oh dear. I think I really broke things here...

@ocefpaf
Copy link
Member

ocefpaf commented May 3, 2023

oh dear. I think I really broke things here...

Screenshot from 2023-05-03 12-41-41

Bad rebase. No problem. I'd just copy the notebook and start a new PR.

@MathewBiddle MathewBiddle mentioned this pull request May 3, 2023
Open
@MathewBiddle
Copy link
Contributor Author

MathewBiddle commented May 3, 2023

see #139

@MathewBiddle MathewBiddle deleted the SCCOOS_HABs branch May 3, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocefpaf ocefpaf Awaiting requested review from ocefpaf

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MathewBiddle @ocefpaf @rsignell-usgs