Ability to set Msbuild properties for design time#1065
Draft
TheAngryByrd wants to merge 2 commits intoionide:mainfrom
Draft
Ability to set Msbuild properties for design time#1065TheAngryByrd wants to merge 2 commits intoionide:mainfrom
TheAngryByrd wants to merge 2 commits intoionide:mainfrom
Conversation
TheAngryByrd
force-pushed
the
msbuildproprties
branch
from
1e7d77f to
6ad1ca3
Compare
Member
Author
|
Hmm what kind of tests do you think would be worth writing for this?
|
Contributor
|
We should take this as an escape hatch if nothing else. I think it could be helpful for configuration changes, but longer term we should do something more structured there instead. When we document it in Ionide it would be good to have inline examples for Configuration. |
TheAngryByrd
force-pushed
the
msbuildproprties
branch
from
6ad1ca3 to
249e9b9
Compare
TheAngryByrd
force-pushed
the
msbuildproprties
branch
from
249e9b9 to
5858481
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ability to change the global properties we pass to design time loading.
MsBuildProps-object-config-2.mp4
(Don't worry about the extra commits, it's build off #1060, I'll rebase when that's merged)