feat(item-divider): add recipe and tokens #31009
+1,687
−443
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,201 @@ | ||
| import type { IonPadding, IonMargin } from '../../themes/themes.interfaces'; | ||
|
|
||
| export type IonItemDividerRecipe = { | ||
| background?: string; | ||
| color?: string; | ||
| minHeight?: string; | ||
|
|
||
| padding?: IonPadding; | ||
|
|
||
| inner?: { | ||
| padding?: IonPadding; | ||
| }; | ||
|
|
||
| border?: { | ||
| bottom?: string; | ||
| }; | ||
|
|
||
| font?: { | ||
| size?: string; | ||
| weight?: string; | ||
| }; | ||
|
|
||
| leading?: { | ||
| // Targets `:host([slot="start"])` | ||
| anchor?: { | ||
| margin?: IonMargin; | ||
| }; | ||
|
|
||
| // Targets `::slotted([slot="start"])` | ||
| edge?: { | ||
| margin?: IonMargin; | ||
| }; | ||
| }; | ||
|
|
||
| trailing?: { | ||
| // Targets `::slotted([slot="end"])` | ||
| edge?: { | ||
| margin?: IonMargin; | ||
| }; | ||
| }; | ||
|
Comment on lines
+23
to
+40
Contributor
Author
There was a problem hiding this comment. 💡 Naming Convention: Anchors & EdgesTo maintain consistency with the Ionic Modular architecture established in
Why this matters: |
||
|
|
||
| label?: { | ||
| margin?: IonMargin; | ||
| }; | ||
|
|
||
| icon?: { | ||
| font?: { | ||
| size?: string; | ||
| }; | ||
|
|
||
| leading?: { | ||
| // Targets `::slotted([slot="start"])` | ||
| edge?: { | ||
| margin?: IonMargin; | ||
| }; | ||
| }; | ||
|
|
||
| trailing?: { | ||
| // Targets `::slotted([slot="end"])` | ||
| edge?: { | ||
| margin?: IonMargin; | ||
| }; | ||
| }; | ||
|
|
||
| // Default non-semantic states | ||
| default?: { | ||
| color?: string; | ||
| }; | ||
|
|
||
| // Any of the semantic colors like primary, secondary, etc. | ||
| semantic?: { | ||
| default?: { | ||
| color?: string; | ||
| }; | ||
| }; | ||
|
Comment on lines
+66
to
+75
Contributor
Author
There was a problem hiding this comment. This follows the same structure established in chip when it came to default vs semantic colors. |
||
| }; | ||
|
|
||
| note?: { | ||
| align?: { | ||
| self?: string; | ||
| }; | ||
|
|
||
| font?: { | ||
| size?: string; | ||
| }; | ||
|
|
||
| margin?: IonMargin; | ||
| padding?: IonPadding; | ||
| }; | ||
|
|
||
| avatar?: { | ||
| height?: string; | ||
| width?: string; | ||
|
|
||
| margin?: IonMargin; | ||
|
|
||
| leading?: { | ||
| // Targets `::slotted([slot="start"])` | ||
| edge?: { | ||
| margin?: IonMargin; | ||
| }; | ||
| }; | ||
|
|
||
| trailing?: { | ||
| // Targets `::slotted([slot="end"])` | ||
| edge?: { | ||
| margin?: IonMargin; | ||
| }; | ||
| }; | ||
| }; | ||
|
|
||
| thumbnail?: { | ||
| height?: string; | ||
| width?: string; | ||
|
|
||
| margin?: IonMargin; | ||
|
|
||
| leading?: { | ||
| // Targets `::slotted([slot="start"])` | ||
| edge?: { | ||
| margin?: IonMargin; | ||
| }; | ||
| }; | ||
|
|
||
| trailing?: { | ||
| // Targets `::slotted([slot="end"])` | ||
| edge?: { | ||
| margin?: IonMargin; | ||
| }; | ||
| }; | ||
| }; | ||
|
|
||
| header1?: { | ||
| margin?: IonMargin; | ||
| }; | ||
|
|
||
| header2?: { | ||
| margin?: IonMargin; | ||
|
|
||
| // Targets `:last-child` | ||
| last?: { | ||
| margin?: IonMargin; | ||
| }; | ||
| }; | ||
|
|
||
| header3?: { | ||
| margin?: IonMargin; | ||
|
|
||
| // Targets `:last-child` | ||
| last?: { | ||
| margin?: IonMargin; | ||
| }; | ||
| }; | ||
|
|
||
| header4?: { | ||
| margin?: IonMargin; | ||
|
|
||
| // Targets `:last-child` | ||
| last?: { | ||
| margin?: IonMargin; | ||
| }; | ||
| }; | ||
|
|
||
| header5?: { | ||
| margin?: IonMargin; | ||
|
|
||
| // Targets `:last-child` | ||
| last?: { | ||
| margin?: IonMargin; | ||
| }; | ||
| }; | ||
|
|
||
| header6?: { | ||
| margin?: IonMargin; | ||
|
|
||
| // Targets `:last-child` | ||
| last?: { | ||
| margin?: IonMargin; | ||
| }; | ||
| }; | ||
|
|
||
| paragraph?: { | ||
| color?: string; | ||
| overflow?: string; | ||
|
|
||
| margin?: IonMargin; | ||
|
|
||
| font?: { | ||
| size?: string; | ||
| }; | ||
|
|
||
| text?: { | ||
| overflow?: string; | ||
| }; | ||
|
|
||
| // Targets `:last-child` | ||
| last?: { | ||
| margin?: IonMargin; | ||
| }; | ||
| }; | ||
| }; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something I noticed:
trailingmeansslot="end"here (and inicon.trailing,avatar.trailing, etc.), but down onheader2.trailing(line 141) it means:last-childwhich is the same meaning chip uses fortrailing. So the same word means two different things within the same recipe. The anchor/edge vocabulary helps but I think this could still trip people up when working across recipes. Worth thinking about whether there's a clearer way to distinguish these?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about this? I also had to update it on chip. b9c7961