Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Code Review
This pull request introduces TypeDoc for automated API documentation generation across the monorepo, adding a central configuration, individual package settings, and new npm scripts. The review feedback identifies that the vertexai package was omitted from the main entry points despite having a configuration file, suggests enabling invalidLink validation to improve documentation quality, and recommends adding missing configuration files for several other packages to ensure they are documented correctly.
a9339b8 to
9255a83
Compare
This comment was marked as resolved.
This comment was marked as resolved.
9255a83 to
2df6eda
Compare
This comment was marked as resolved.
This comment was marked as resolved.
2df6eda to
a2b6603
Compare
This comment was marked as resolved.
This comment was marked as resolved.
a2b6603 to
2a5cd26
Compare
This comment was marked as resolved.
This comment was marked as resolved.
2a5cd26 to
054334b
Compare
|
You have used all of your free Bugbot PR reviews. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
|
I need to merge this one so I can get it published, otherwise I don't have a good way to verify the gatsby / non-reference website for broken links with a crawler, so remapping reference links is more difficult |
Description
Our reference API site is currently built using a customized typedoc JSON output converter written in Gatsby - it is all out of date and doesn't work well with our new typescript-converted modules.
This PR implements a typedoc config that is very close to stock typedoc recommendations for monorepos with no plugins and raw HTML output
It then implements a publish of that output to github pages as a new step in the publish.yml workflow so that our reference API is updated to match the current release on main as the release goes out.
A future PR will modify the existing docs generator in
website/so that it no longer generates a reference API site internally, and all reference API links are rewritten to link to the new github pages site for reference API docs - need to merge this and publish first so that I can run a link checker on the non-reference site during re-mapping to make sure all reference links resolve in their new homeRelated issues
Release Summary
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
1- Check out this branch / PR
2- run
yarn && yarn reference:api3- using a browser, open
reference/index.html1- After merge, attempt a manual / workflow-dispatch run of just the reference API publish workflow
2- and a publish of the whole repo which should also publish the reference API via a workflow call at end of publish workflow
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter