Skip to content

ci(macos): fix macos test runner#8947

Merged
russellwheatley merged 4 commits intomainfrom
fix-macos-test-runner
Mar 31, 2026
Merged

ci(macos): fix macos test runner#8947
russellwheatley merged 4 commits intomainfrom
fix-macos-test-runner

Conversation

@russellwheatley
Copy link
Copy Markdown
Member

Description

  • backported the React Native fmt update from 11.0.2 to 12.1.0 into the react-native-macos podspec patch so Xcode 26.4 can compile the macOS test app again.
  • updated the macOS test app target to disable Xcode’s Debug dylib layout and corrected the Info.plist path casing, so Jet can launch the built .app normally in CI.

Reference for the dependency bump: facebook/react-native#56099

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@russellwheatley russellwheatley changed the title Fix macos test runner ci(macos): fix macos test runner Mar 31, 2026
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-native-firebase Error Error Mar 31, 2026 2:49pm

Request Review

Copy link
Copy Markdown
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - looks high-precision and accurate, +1 if CI goes green

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the fmt library version from 11.0.2 to 12.1.0 across the project, including updates to Podfile.lock and a patch for react-native-macos podspecs. Additionally, it modifies the macOS project configuration to disable ENABLE_DEBUG_DYLIB and corrects the casing of the INFOPLIST_FILE path. I have no feedback to provide.

@russellwheatley russellwheatley marked this pull request as ready for review March 31, 2026 15:18
@russellwheatley russellwheatley merged commit 8782070 into main Mar 31, 2026
21 of 22 checks passed
@russellwheatley russellwheatley deleted the fix-macos-test-runner branch March 31, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants