Conversation
|
Please consider this PR.
It would also make sense to remove Python 2 compatibility altogether, since it was EOL nearly 2 years ago. |
jonahgeorge
added a commit
to jonahgeorge/oauth-pythonclient
that referenced
this pull request
Sep 21, 2023
|
This is needed for python 3.12. Please consider this PR @nicholas-ramsey as this library is no longer compatible with python 3.12. |
Contributor
|
@alanyee This has been implemented, seems like this can be closed. |
Author
|
@bdsoha I will close this PR since it is no longer needed, but this PR was to make it Python 2 compatible. With the new change, Python 3 should be enforced by |
Author
|
#46 is the small iteration of this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a thirdparty dependency as big as
futurefor justurlencode()does not seem worth it