Conversation
Co-authored-by: mythi <1049565+mythi@users.noreply.github.com>
|
@copilot golangci-lint action and Makefile must be updated to at least v2.9.0 version of golangci-lint: "Error: can't load config: the Go language version (go1.25) used to build golangci-lint is lower than the targeted Go version (1.26.0)" |
Co-authored-by: mythi <1049565+mythi@users.noreply.github.com>
Updated golangci-lint from v2.7.2 to v2.9.0 in both |
|
@copilot this one also triggers with Go 1.26: Error: pkg/topology/topology_test.go:218:25: (*testing.common).Fatalf format %q has arg len(test.output) of wrong type int |
Co-authored-by: mythi <1049565+mythi@users.noreply.github.com>
|
@copilot configure golangci-lint to disable |
Co-authored-by: mythi <1049565+mythi@users.noreply.github.com>
|
@copilot change default_args.docker and all Dockerfiles to: add a commit message: removing all= limits the flags to the package being built, instead of forcing them onto the full dependency graph and Go runtime, which breaks under Go 1.26 |
…tead of forcing them onto the full dependency graph and Go runtime, which breaks under Go 1.26 Co-authored-by: mythi <1049565+mythi@users.noreply.github.com>
|
@copilot merge the latest main to the working branch and enable |
Co-authored-by: mythi <1049565+mythi@users.noreply.github.com> Agent-Logs-Url: https://github.com/intel/intel-device-plugins-for-kubernetes/sessions/cb22f40c-1658-4649-a977-45914ec4b9ae
This is a regression in Go 1.26.x. Will wait to see if that gets resolved. |
go.modfromgo 1.25.0togo 1.26.0Makefilefromgolang:1.25-trixietogolang:1.26-trixiebuild/docker/lib/golang_base.dockerfromgolang:1.25-trixietogolang:1.26-trixiebuild/docker/build-image.shGo version referencebuild/docker/that referencegolang:1.25-trixiebuild/docker/templates/intel-gpu-levelzero.Dockerfile.intemplatebuild/docker/templates/intel-gpu-levelzero.ubi.Dockerfile.intemplate (CGO_VERSION=1.25→CGO_VERSION=1.26)build/docker/intel-gpu-levelzero.Dockerfile(generated file)build/docker/intel-gpu-levelzero.ubi.Dockerfile(generated file)Makefileand.github/workflows/lib-validate.yaml(required for Go 1.26 support)pkg/topology/topology_test.go:218— replace%qwith%dfor integerlen()values (Go 1.26 stricter format checking)all=prefix fromGCFLAGSandASMFLAGSinbuild/docker/lib/default_args.dockerand all Dockerfiles — removingall=limits the flags to the package being built, instead of forcing them onto the full dependency graph and Go runtime, which breaks under Go 1.26💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.