[v12] feat(ui-pagination): Pagination rework new v12#2432
Open
git-nandor wants to merge 5 commits intov12from
Open
[v12] feat(ui-pagination): Pagination rework new v12#2432git-nandor wants to merge 5 commits intov12from
git-nandor wants to merge 5 commits intov12from
Conversation
|
git-nandor
force-pushed
the
INSTUI-4799_pagination_rework_new_v12
branch
from
6952f5a to
3131b71
Compare
joyenjoyer
requested changes
Mar 9, 2026
git-nandor
force-pushed
the
INSTUI-4799_pagination_rework_new_v12
branch
4 times, most recently
from
2a94341 to
548ee30
Compare
Collaborator
This value was 0.25rem so it was wrong, I updated it so now its 0.5rem but based on the screenshot it looks like it doesn't get the value at all |
git-nandor
force-pushed
the
INSTUI-4799_pagination_rework_new_v12
branch
from
bbb380d to
91d446e
Compare
Contributor
Author
New token value is added |
git-nandor
force-pushed
the
INSTUI-4799_pagination_rework_new_v12
branch
from
91d446e to
1b87d9e
Compare
joyenjoyer
reviewed
Mar 11, 2026
| // const showRebrandThemes = | ||
| // this.state.showMinorVersionSelector && | ||
| // this.state.selectedMinorVersion !== 'v11_6' | ||
| const showRebrandThemes = true // TODO temp workaround for design review |
Contributor
There was a problem hiding this comment.
Is this part still needed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INSTUI-4799
Summary
Migrated Pagination component from the old theming system.
Test plan
On the documentation page, verify that everything displays and works correctly.
Co-Authored-By: 🤖 Claude