[MBL-19975][Teacher] Section filter doesn't function within Attendance#3683
Closed
kristofnemere wants to merge 1 commit into
Closed
[MBL-19975][Teacher] Section filter doesn't function within Attendance#3683kristofnemere wants to merge 1 commit into
kristofnemere wants to merge 1 commit into
Conversation
The Attendance screen overlays a hidden Roll Call WebView with a LinearLayout that wasn't consuming touches. Taps in the section-name area fell through to the WebView's <select>, opening a section picker that didn't update the native UI. Make the LinearLayout clickable so touches are absorbed and the top-right toolbar filter remains the only section-change entry point. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
kristofnemere
changed the title
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary
This PR adds android:clickable="true" to the LinearLayout overlay in fragment_attendance_list.xml. The layout structure is a FrameLayout containing a full-screen WebView with a LinearLayout overlay on top. Without clickable="true", touch events on empty areas of the LinearLayout pass through to the WebView underneath — this change blocks that bleed-through.
Review observations
- Correctness: The fix is targeted and addresses the root cause (transparent overlay regions not consuming touch events).
- Convention: The
clickable="true"pattern is already used in other teacher layouts (fragment_assignment_list.xml,fragment_people_list_layout.xml, etc.), so this is consistent with codebase conventions. - Scope: Minimal, single-line change — appropriate for the apparent bug fix.
Items to verify
- Confirm the underlying WebView is intentional and that suppressing touch events on it (rather than hiding it / setting
visibility="gone"when the overlay is shown) is the desired behavior. If the WebView is only used as a rendering surface for content that should never receive direct touch, this fix is correct; otherwise, consider whether the WebView'simportantForAccessibility="no"and the new touch-blocking together accurately model the intended interaction. - Manually verify that taps on empty LinearLayout regions (e.g., between the toolbar and the recycler) no longer trigger any WebView interaction or scrolling.
- No automated tests are included — confirm whether this regression is already covered by an existing Espresso test, or whether one should be added to prevent recurrence.
No blocking concerns; submitting as non-blocking feedback.
Contributor
🧪 Unit Test Results✅ 📱 Teacher App
✅ 📦 Submodules
📊 Summary
Last updated: Mon, 11 May 2026 11:46:22 GMT |
Contributor
📊 Code Coverage Reportℹ️ Student
ℹ️ Teacher
ℹ️ Pandautils
|
Contributor
|
Teacher Install Page |
tamaskozmer
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan:
refs: MBL-19975
affects: Teacher
release note: Fixed an issue where tapping the section name in the Teacher Attendance screen opened a non-functional section picker.
Checklist