Allow documents to be loaded locally for Knowledge Injection#388
Closed
murthyrudra wants to merge 1 commit intoinstructlab:mainfrom
Closed
Allow documents to be loaded locally for Knowledge Injection#388murthyrudra wants to merge 1 commit intoinstructlab:mainfrom
murthyrudra wants to merge 1 commit intoinstructlab:mainfrom
Conversation
6 tasks
Contributor
|
The change to the schema was never approved/merged, so I'm holding off reviewing the implementation here until it's decided to support local knowledge docs at the schema level. |
Contributor
|
Given that we're making a plan right now to move most of this document ingestion code to the instructlab/instructlab repository, and that there's no movement on the pre-requisite PR in the schema repo, I'm closing this for now. If or when a new knowledge schema gets created that supports local knowledge documents, we're happy to accept contributions or work together on the implementation of that. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature allows users to specify the local folder path instead of github repo for knowledge injection. Specifically, the update modifies the
validate_documentfunction to search for files locally and ensure the documents follow the prescribed format.This feature includes an update to the
schemarepo and the corresponding PR is here