Draft
Conversation
inducer
force-pushed
the
add-more-gmsh-reading-tests
branch
from
6b19818 to
b143bfd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change set adds a few configurations of a simple 3x3 tensor product element mesh generated by
gmshin order to test that 2Dgmshreading is OK. 4 basic tests are added, but in the end we probably don't need them all.3x3: positively oriented (counter-clockwise element connectivities)
3x3_twisted: positively oriented, but turned so that the el conn doesn't always start with the lower left vertex
3x3_minus: negatively oriented (clockwise element connectivities)
3x3_bound: negatively oriented w/domain boundaries
The two negatively oriented meshes trigger a re-read with the
force_positive_orientation=Trueoption set - just to make sure that it works. The final mesh with the domain boundaries currently fails because theforce_positive_orientation=Trueoption loses boundary information.CC: @inducer, @anderson2981