fix(cache): prevent bloom filter from rejecting reads on existing caches#20
Merged
fix(cache): prevent bloom filter from rejecting reads on existing caches#20
Conversation
The bloom filter was incorrectly blocking all reads from existing caches because it was empty on startup - it wasn't populated from the persisted cache data. Added _bloomPopulated flag that is only set to true when keys are added via set(). The bloom filter check in fetch() and has() now only applies when this flag is true, allowing reads from existing caches to work. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_bloomPopulatedflag that tracks whether the bloom filter has been populated viaset()operationsfetch()andhas()now only apply when the flag is trueProblem
When opening an existing cache, the bloom filter was empty (not loaded from persisted data). This caused
cache.fetch(key)to returnnullfor all keys because the empty bloom filter reported they didn't exist.Solution
Only use the bloom filter for negative lookups when it has been populated during this session. This allows reads from existing caches to work correctly while still benefiting from bloom filter optimization for keys added during the current session.
Test plan
cache exportcommand works on existing cache data🤖 Generated with Claude Code