fix(packument): preserve URL path segments when constructing request URLs#19
Merged
fix(packument): preserve URL path segments when constructing request URLs#19
Conversation
…URLs
The PackumentClient was using `new URL('/${package}', origin)` which
replaces the entire pathname of the base URL rather than appending to it.
This caused registries with path segments (e.g., /javascript) to lose
their path when constructing package URLs.
Before: https://registry.example.com/javascript + lodash
=> https://registry.example.com/lodash (wrong)
After: https://registry.example.com/javascript + lodash
=> https://registry.example.com/javascript/lodash (correct)
Also adds comprehensive tests for PackumentClient covering:
- URL construction with various path configurations
- Basic packument fetching from npm
- Scoped package handling
- 404 response handling
- Batch requests via requestAll()
indexzero
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PackumentClient was using
new URL('/${package}', origin)which replaces the entire pathname of the base URL rather than appending to it. This caused registries with path segments (e.g., /javascript) to lose their path when constructing package URLs.Also adds comprehensive tests for PackumentClient covering: