Conversation
| box-shadow: 0 5px 50px 0 rgba(0, 0, 0, 0.1); | ||
| margin: 0; | ||
| padding: 0; | ||
| min-height: 100vh; // temp |
There was a problem hiding this comment.
you forgot to remove the temp lol
|
|
||
|
|
||
|
|
||
| .SVGContainer |
There was a problem hiding this comment.
you have a bunch of random styling here, id like you reformat this to have align-self: center along with padding-right: X to push it to the right like on the design
| max-width: none; | ||
| } | ||
|
|
||
| .SVGContainer .softwareSVG{ |
| aspect-ratio: 1/1; | ||
|
|
||
| } | ||
| :root{ |
There was a problem hiding this comment.
for your colors please use the ones in _globals/globals.scss
| font-family: "Space Grotesk"; | ||
| font-size: 1rem; | ||
| font-weight: 500; | ||
| margin-bottom: 0.75rem; |
There was a problem hiding this comment.
can u remove margins and make it a bigger gap instead in .sssbuttonscontainer
| margin-bottom: 0.75rem; | ||
| margin-left: 0.21rem; | ||
| padding: 0.625rem; | ||
| width: 19.6875rem; |
There was a problem hiding this comment.
try not to set height and widths for something like this, use padding instead
There was a problem hiding this comment.
final thing, can u rename ur files from page to like software-work or something and captalize your function name
| </div> | ||
|
|
||
| <div className={styles.SVGContainer}> | ||
| <svg |
There was a problem hiding this comment.
can u move this svg to an svg file in .public and use <Image .../>
kyharac
left a comment
kyharac
left a comment
There was a problem hiding this comment.
agree with everything austin commented, for the SVG, not sure if we went over it on our meetings, but ask us if you need help!
3 participants
Description
Made the software work page. {"button" has a hover animation}
Checklist:
after creating your PR please mark all of these: