transpile: Move some translation from convert_address_of_common to convert_literal#1633
Merged
kkysen merged 2 commits intoimmunant:masterfrom Mar 3, 2026
Merged
Conversation
Rua
force-pushed
the
convert-literal-refactor
branch
3 times, most recently
from
16797b7 to
37ec6a0
Compare
kkysen
approved these changes
Mar 3, 2026
Contributor
kkysen
left a comment
kkysen
left a comment
There was a problem hiding this comment.
Just one little nit, but otherwise it LGTM! Thanks!
Rua
force-pushed
the
convert-literal-refactor
branch
from
37ec6a0 to
b30aa5d
Compare
kkysen
approved these changes
Mar 3, 2026
Rua
force-pushed
the
convert-literal-refactor
branch
from
b30aa5d to
f2c0bf4
Compare
Rua
force-pushed
the
convert-literal-refactor
branch
from
f2c0bf4 to
6659130
Compare
kkysen
reviewed
Mar 3, 2026
kkysen
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than
convert_address_of_commoncompletely discarding the previously translatedvalfor string literals, it now does part of the correct translation inconvert_literalso that no discarding is needed. This will probably be needed to get #1628 working, sinceadd_feature(for const blocks) will have an effect even if code is discarded.Also,
as_ptris now used, to be consistent with other kinds of array.