transpile: Translate enums with newtype structs

[Rua]

No description provided.

[Rua]

It seems that the transpiler is generating working code, but then the refactorer is breaking the imports. I don't know if that's simply a bug in the refactorer, or something else.

Edit: wondering if the refactorer is not handling impl blocks properly, to support associated constants?

[kkysen]

Btw, #1623 should help with the error messages here, which I saw were atrocious (#1621).

[Rua]

The errors from refactor don't seem to have gone away. This PR hasn't changed anything about refactor, so is that a bug in the refactorer?

[kkysen]

The errors from refactor don't seem to have gone away. This PR hasn't changed anything about refactor, so is that a bug in the refactorer?

Oh sorry, I meant #1623 should help make the error messages legible, but not fix them.

This is likely either a bug in the refactorer, or the refactorer is assuming something about what code the transpiler generates for enums and now can't handle a different translation of enums. If it's the latter, we should probably fix it here.

[Rua]

I've not looked at the refactorer code at all yet, so I wouldn't really know where to look for a possible cause. The CI error messages don't give much of a hint.

[kkysen]

I've not looked at the refactorer code at all yet, so I wouldn't really know where to look for a possible cause. The CI error messages don't give much of a hint.

@ahomescu, do you have any idea maybe?

[ahomescu]

Could you share the refactorer errors you're getting?

[Rua]

The errors are happening in CI. I can't run the tests on NixOS myself.

[Rua]

I've removed the second commit from the PR, the one that uses associated constants instead of global ones. That seems to be the one that the refactorer has trouble with.

EDIT: I guess not? Hmm.

[ahomescu]

If you run the transpiler with --reorganize-definitions (we're renaming that btw, but I don't think it has landed), are you maybe missing the c2rust::src_loc attributes on the newtypes?