Skip to content

GH-158 Refactor PlayTimeApiProvider to use AtomicReference for thread-safe registration #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imDMK merged 2 commits into from
Mar 2, 2026
Merged

GH-158 Refactor PlayTimeApiProvider to use AtomicReference for thread-safe registration #158

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fd933d
refactor: replace synchronized access with AtomicReference
imDMK Mar 2, 2026
4948484
Follow Gemini review suggestions.
imDMK Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions playtime-api/src/main/java/com/github/imdmk/playtime/PlayTimeApiProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,38 +2,38 @@

import org.jetbrains.annotations.NotNull;

import java.util.concurrent.atomic.AtomicReference;

public final class PlayTimeApiProvider {

private static volatile PlayTimeApi API; // visibility across threads
private static final AtomicReference<PlayTimeApi> API = new AtomicReference<>();

private PlayTimeApiProvider() {
throw new UnsupportedOperationException("This class cannot be instantiated.");
}

@NotNull
public static PlayTimeApi get() {
final PlayTimeApi api = API;
final PlayTimeApi api = API.get();
if (api == null) {
throw new IllegalStateException("PlayTimeAPI is not registered.");
}
return api;
}

public static boolean isRegistered() {
return API != null;
return API.get() != null;
}

static synchronized void register(@NotNull PlayTimeApi api) {
if (API != null) {
static void register(@NotNull PlayTimeApi api) {
if (!API.compareAndSet(null, api)) {
throw new IllegalStateException("PlayTimeAPI is already registered.");
}
API = api;
}

static synchronized void unregister() {
if (API == null) {
static void unregister() {
if (API.getAndSet(null) == null) {
throw new IllegalStateException("PlayTimeAPI is not registered.");
}
API = null;
}
}
}
Loading