libnvme/nvme: clean up and order includes in src/nvme/ source files

[Copilot]

Review of #include directives across all files in libnvme/src/nvme/ — removing duplicates and unused headers, and ordering all includes per the commonly recommended convention.

Duplicate includes removed

• mi.c: <stdlib.h> included twice consecutively
• generate-accessors.c: <string.h> and <stdio.h> each included twice (once near the top, once mid-block)

Unused includes removed

File	Header	Reason
ioctl.c	<inttypes.h>	No PRI format macros used; <stdint.h> already included directly for uintptr_t
ioctl.c	<sys/time.h>	No timeval / gettimeofday usage
base64.c	<sys/types.h>	Only uint32_t used, covered by <stdint.h>
log.c	<sys/types.h>	No POSIX types used; getpid() pulled in via <unistd.h>

Include ordering applied across all files

The following ordering convention is now applied consistently across all 22 affected .c and .h files:

1. Standard/POSIX headers (alphabetical)
2. System headers with path prefix: sys/, arpa/, linux/, net/ (alphabetical)
3. Third-party library headers: ccan, dbus, json, keyutils, liburing, openssl (alphabetical)
4. Project public headers: <libnvme.h>, <nvme/...>
5. Local/private headers: "..."

Notable structural fixes:

• lib.c: system headers were placed after local "private.h" includes
• no-json.c: standard <errno.h> was placed after project <libnvme.h>
• cmds.h: standard headers were placed after project <nvme/...> headers
• private.h: ccan headers appeared before sys/ and POSIX headers
• ioctl.c: conditional <liburing.h> was embedded inside the standard headers block
• linux.c: <fcntl.h> and <unistd.h> were grouped with sys/* headers

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[igaw]

@copilot while at it also order header like it is commonly recommended

[Copilot]

@copilot while at it also order header like it is commonly recommended

Done in 0c04705. Applied the commonly recommended ordering across all 22 affected files in libnvme/src/nvme/:

1. Standard/POSIX headers (alphabetical)
2. System headers with path prefix (sys/, arpa/, linux/, net/) (alphabetical)
3. Third-party library headers (ccan, dbus, json, keyutils, liburing, openssl) (alphabetical)
4. Project public headers (libnvme.h, <nvme/...>)
5. Local/private headers ("...")

The most significant structural fixes were lib.c (system headers were below local includes), no-json.c (<errno.h> after <libnvme.h>), cmds.h (standard headers after project headers), private.h (ccan before sys/), and ioctl.c (conditional <liburing.h> moved out of the standard headers block to the third-party section).