Render operating system name as well as architecture if present #3653
+32
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ILSpy/Languages/Language.cs
Outdated
|
|
||
| if (!Enum.IsDefined(architecture)) | ||
| { | ||
| foreach (var kvp in osMachineLookup) |
Member
There was a problem hiding this comment.
I would've used tuple deconstruction syntax here for clarity
MatthewSteeples
force-pushed
the
master
branch
from
147ad12 to
65129b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was diagnosing an issue with our ReadyToRun assemblies and when I loaded them in ILSpy I noticed that instead of indicating which platform they were built for it was just a number.
Digging into it, I found this comment that indicates that if the binaries are machine specific then the value is xor'd with a constant (like flags).
This Pull Request displays the OS (if present).
I'm happy for the format of the text output to be changed, or any other changes for that matter!