Open
Conversation
Steveb-p
force-pushed
the
ibx-11493/language-code-validation
branch
from
8a5e2cf to
4e03481
Compare
Steveb-p
force-pushed
the
ibx-11493/language-code-validation
branch
from
4e03481 to
8dac6a5
Compare
Steveb-p
force-pushed
the
ibx-11493/language-code-validation
branch
from
8dac6a5 to
85a616c
Compare
…anguageCreateStruct`
…anguageCreateStruct`
…anguageCreateStruct`
…lid language code tests
Steveb-p
force-pushed
the
ibx-11493/language-code-validation
branch
from
90267e6 to
4f830d7
Compare
ibexa-workflow-automation-1
bot
requested review from
ViniTou,
alongosz,
barw4,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
…l` instead of `IbexaSolrTestKernel`
…Kernel` and added `CoreSolrTestKernel` implementation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds metadata to
LanguageCreateStruct, with regex condition for the shape of the language code.Additionally, it refactors
LanguageServiceTestcode to use newer integration test setup, since the original one was usingDummyValidatorservice, which prevented the test from performing correctly.Tested manually against a migration:
Result:
Technically, operations that directly preceed the validator could be moved into validator itself as well (is name empty, is code empty, is code used already?), but I opted not to - since they would introduce more complexity to this PR. Can be done as a follow up if desired.
For QA:
Documentation: