Skip to content

[PHPStan] Defined array shapes for Liip filter configuration#733

Merged
alongosz merged 2 commits into4.6from
phpstan-cleanup-liip-filter-configuration
Mar 23, 2026
Merged

[PHPStan] Defined array shapes for Liip filter configuration#733
alongosz merged 2 commits into4.6from
phpstan-cleanup-liip-filter-configuration

Conversation

@alongosz
Copy link
Member

🎫 Issue n/a

Related PRs:

Description:

When reviewing another PR I've noticed that PHPStan started failing with

 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   src/bundle/Core/Imagine/Filter/FilterConfiguration.php                                                                                                                 
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  38     Parameter #2 $configuredVariations of method Ibexa\Bundle\Core\Imagine\Filter\FilterConfiguration::getVariationFilters() expects array, non-empty-array given.         
         🪪  argument.type                                                                                                                                                      
  39     Parameter #2 $configuredVariations of method Ibexa\Bundle\Core\Imagine\Filter\FilterConfiguration::getVariationPostProcessors() expects array, non-empty-array given.  
         🪪  argument.type                                                                                                                                                      
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- 

Junior Dev helped cleaning up a bit of legacy mess in Image semantic config and FilterConfiguration by adding proper array shapes.

For QA:

No QA required. CI test suites + behat should be enough.

Documentation:

No doc required.

@alongosz alongosz force-pushed the phpstan-cleanup-liip-filter-configuration branch from 743c8f7 to 9cc3092 Compare March 20, 2026 14:42
@sonarqubecloud
Copy link

@alongosz alongosz merged commit 37e312c into 4.6 Mar 23, 2026
64 of 75 checks passed
@alongosz alongosz deleted the phpstan-cleanup-liip-filter-configuration branch March 23, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants