IBX-10734: simplexml_load_string() throws an exception on ezselection fields when using libxml2 2.13.8 and higher

src/lib/Persistence/Legacy/Content/FieldValue/Converter/SelectionConverter.php

@@ -100,7 +100,7 @@
      * @param \Ibexa\Core\Persistence\Legacy\Content\StorageFieldDefinition $storageDef
      * @param \Ibexa\Contracts\Core\Persistence\Content\Type\FieldDefinition $fieldDef
      */
     public function toFieldDefinition(StorageFieldDefinition $storageDef, FieldDefinition $fieldDef)
     {
         $options = [];
         $multiLingualOptions = [$fieldDef->mainLanguageCode => []];
@@ -119,7 +119,7 @@
         }
 
         foreach ($storageDef->multilingualData as $languageCode => $mlData) {
-            $xml = simplexml_load_string($mlData->dataText);
+            $xml = $mlData->dataText ? simplexml_load_string($mlData->dataText) : false;
             if ($xml !== false) {
                 foreach ($xml->options->option as $option) {
                     $multiLingualOptions[$languageCode][(int)$option['id']] = (string)$option['name'];

tests/lib/Persistence/Legacy/Content/FieldValue/Converter/SelectionTest.php

@@ -11,6 +11,7 @@
 use Ibexa\Contracts\Core\Persistence\Content\Type\FieldDefinition as PersistenceFieldDefinition;
 use Ibexa\Core\FieldType\FieldSettings;
 use Ibexa\Core\Persistence\Legacy\Content\FieldValue\Converter\SelectionConverter;
+use Ibexa\Core\Persistence\Legacy\Content\MultilingualStorageFieldDefinition;
 use Ibexa\Core\Persistence\Legacy\Content\StorageFieldDefinition;
 use Ibexa\Core\Persistence\Legacy\Content\StorageFieldValue;
 use PHPUnit\Framework\TestCase;
@@ -325,6 +326,43 @@ public function testToFieldDefinitionSingleEmpty()
 
         $this->assertEquals($expectedFieldDefinition, $actualFieldDefinition);
     }
+
+    public function testToFieldDefinitionWithMultilingualDataSkipsEmptyDataText(): void
+    {
+        $storageFieldDefinition = new StorageFieldDefinition();
+        $storageFieldDefinition->dataInt1 = 1;
+        $storageFieldDefinition->dataText5 = <<<EOT
+<?xml version="1.0" encoding="utf-8"?>
+<ezselection><options><option id="0" name="First"/></options></ezselection>
+EOT;
+
+        $mlDataEmpty = new MultilingualStorageFieldDefinition();
+        $mlDataEmpty->dataText = '';
+
+        $mlDataValid = new MultilingualStorageFieldDefinition();
+        $mlDataValid->dataText = <<<EOT
+<?xml version="1.0" encoding="utf-8"?>
+<ezselection><options><option id="0" name="Premier"/></options></ezselection>
+EOT;
+
+        $storageFieldDefinition->multilingualData = [
+            'eng-GB' => $mlDataEmpty,
+            'fre-FR' => $mlDataValid,
+        ];
+
+        $actualFieldDefinition = new PersistenceFieldDefinition(
+            [
+                'mainLanguageCode' => 'eng-GB',
+            ]
+        );
+
+        $this->converter->toFieldDefinition($storageFieldDefinition, $actualFieldDefinition);
+
+        $fieldSettings = $actualFieldDefinition->fieldTypeConstraints->fieldSettings;
+
+        self::assertSame([0 => 'First'], $fieldSettings['multilingualOptions']['eng-GB']);
+        self::assertSame([0 => 'Premier'], $fieldSettings['multilingualOptions']['fre-FR']);
+    }
 }
 
 class_alias(SelectionTest::class, 'eZ\Publish\Core\Persistence\Legacy\Tests\Content\FieldValue\Converter\SelectionTest');