fix: allow Premium users to use tracking pixel subscriber identify#840
Open
faisalahammad wants to merge 1 commit intoibericode:mainfrom
Open
fix: allow Premium users to use tracking pixel subscriber identify#840faisalahammad wants to merge 1 commit intoibericode:mainfrom
faisalahammad wants to merge 1 commit intoibericode:mainfrom
Conversation
Moves the Premium E-Commerce duplicate-script guard from the bootstrap (where it blocked the entire class) into output_tracking_script() (where it only prevents the script from being loaded twice). This allows Premium users to: - Use the auto-connect flow to register/find their connected site - Identify subscribers via the pixel SDK after form sign-ups - See and configure the setting in the admin UI Also reads mc4wp_ecommerce['mcjs_url'] as a fallback script URL source, so both integrations share the same connected site without redundant API calls.
faisalahammad
force-pushed
the
fix/830-premium-tracking-pixel-compat
branch
from
d372897 to
5ce9dfe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #832. Fixes the issue where Premium E-Commerce users were locked out of the tracking pixel feature entirely.
The
is_premium_ecommerce_pixel_active()guard has been moved from the bootstrap (where it blocked class instantiation) intooutput_tracking_script()(where it only prevents a duplicate script tag). Premium users can now use the auto-connect flow, the subscriber identify call, and see the settings UI.Also reads
mc4wp_ecommerce['mcjs_url']as a fallback script URL source so both integrations can share the same connected site without redundant API calls.