fix(auth): restore tty browser login menu and cover omitted inputs#26
Merged
Conversation
- Remove the inputs guard from the interactive browser auth path so TTY users can reach the account-adding menu even when no prompt data is passed. - Target: auth
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the OpenCode TTY login regression where the browser auth menu was skipped when
authorize()was called without aninputsobject.What's included:
cache-lockfallback changesauthorize()inputs in TTY modeOPENCODE_NO_BROWSER=1path to satisfy the ratchetVerification:
npm test -- test/codex-native-oauth-auth-methods.test.ts test/codex-native-auth-menu-wiring.test.tsnpm run typecheck:testnpm run verify