Skip to content

Remove keep_keys parameter from SagemcomClient #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iMicknl merged 1 commit into from
Apr 7, 2026
Merged

Remove keep_keys parameter from SagemcomClient #463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions sagemcom_api/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ def __init__(
session: ClientSession | None = None,
ssl: bool | None = False,
verify_ssl: bool | None = True,
keep_keys: bool = False,
):
"""Create a SagemCom client.

Expand All @@ -87,13 +86,11 @@ def __init__(
:param password: the password for your Sagemcom router
:param authentication_method: the auth method of your Sagemcom router
:param session: use a custom session, for example to configure the timeout
:param keep_keys: return response keys as originally written (no snake_case conversion)
"""
self.host = host
self.username = username
self.authentication_method = authentication_method
self.password = password
self.keep_keys = keep_keys
self._current_nonce = None
self._password_hash = self.__generate_hash(password)
self.protocol = "https" if ssl else "http"
Expand Down Expand Up @@ -195,7 +192,7 @@ def __get_response(self, response, index=0):

return value

def __get_response_value(self, response, index=0, keep_keys: bool | None = None):
def __get_response_value(self, response, index=0):
"""Retrieve response value from value."""
try:
value = self.__get_response(response, index)["value"]
Expand All @@ -204,9 +201,8 @@ def __get_response_value(self, response, index=0, keep_keys: bool | None = None)
except IndexError:
value = None

# Rewrite result to snake_case unless keep_keys is requested
should_keep = keep_keys if keep_keys is not None else self.keep_keys
if value is not None and not should_keep:
# Rewrite result to snake_case
if value is not None:
value = humps.decamelize(value)

return value
Expand Down
Loading