Skip to content

Comments

Make Some Classes Into Records#300

Closed
BrandonSchmitt wants to merge 1 commit intohypfvieh:masterfrom
BrandonSchmitt:small-code-improvements
Closed

Make Some Classes Into Records#300
BrandonSchmitt wants to merge 1 commit intohypfvieh:masterfrom
BrandonSchmitt:small-code-improvements

Conversation

@BrandonSchmitt
Copy link
Contributor

The following classes have become records:

  • ClassBuilderInfo$AnnotationInfo
  • DBusPath
  • FileDescriptor
  • LoggingHelperTest$TestValues
  • MethodTuple
  • PropertyRef
  • TextFile

The following classes have become records:
- ClassBuilderInfo$AnnotationInfo
- DBusPath
- FileDescriptor
- LoggingHelperTest$TestValues
- MethodTuple
- PropertyRef
- TextFile
@hypfvieh
Copy link
Owner

I can't see the benefit in changing random classes to record.

DBusPath and FileDescriptor are exposed to the user and the change will introduce API breaks without adding any value.

So thank you, but no I don't gonna merge this PR.

@hypfvieh hypfvieh closed this Feb 20, 2026
@BrandonSchmitt
Copy link
Contributor Author

All good. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants