Merged
Conversation
I focused on low-hanging fruits that my IDE proposed while making sure, not to change behavior or potentially breaking any API usage. The changes include but are not limited to: - replacing lambdas with method references - Simplifying conditions - Using methods from the JDK over custom ones. - Removing No-Ops
BrandonSchmitt
commented
Feb 19, 2026
dbus-java-core/src/main/java/org/freedesktop/dbus/connections/base/FallbackContainer.java
Show resolved
Hide resolved
Contributor
Author
There was a problem hiding this comment.
Explanation: The variable _sock is of type SocketChannel which implements NetworkChannel. So, the check _sock instanceof NetworkChannel can only be false if it is null. The else branch can then only be entered if it is indeed null. I wondered... Doesn't aut.getUid(null) always return -1? There might be more code that could be removed.
Owner
There was a problem hiding this comment.
Looks like this is a bigger bug you discovered.
When you check where getUid() is implemented, the code should return something more useful than -1 when a non-null value is given. I'll take a look at that.
dbus-java-core/src/main/java/org/freedesktop/dbus/matchrules/DBusMatchRule.java
Show resolved
Hide resolved
dbus-java-core/src/main/java/org/freedesktop/dbus/matchrules/MatchRuleField.java
Show resolved
Hide resolved
dbus-java-core/src/main/java/org/freedesktop/dbus/utils/PrimitiveUtils.java
Show resolved
Hide resolved
dbus-java-core/src/main/java/org/freedesktop/dbus/RemoteInvocationHandler.java
Show resolved
Hide resolved
hypfvieh
reviewed
Feb 19, 2026
| dbi = connection.dynamicProxy(source, path, type); | ||
| assertNotNull(dbi); | ||
| assertTrue(TestInterfaceType.class.isInstance(dbi)); | ||
| assertTrue(dbi instanceof TestInterfaceType); |
Owner
There was a problem hiding this comment.
This one can also be replace with assertInstanceOf. I'll fix that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I focused on low-hanging fruits that my IDE proposed while making sure, not to change behavior or potentially breaking any API usage. The changes include but are not limited to: