chore(ci): Maximize CI/CD values (Dependabot & Permissions)#29
chore(ci): Maximize CI/CD values (Dependabot & Permissions)#29hyperpolymath merged 4 commits intomainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 01ab6de9dd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Trigger BoJ Server (Casket/ssg-mcp) | ||
| run: | | ||
| # Send a secure trigger to boj-server to build this repository | ||
| curl -X POST "http://boj-server.local:7700/cartridges/ssg-mcp/invoke" -H "Content-Type: application/json" -d "{\"repo\": \"${{ github.repository }}\", \"branch\": \"${{ github.ref_name }}\", \"engine\": \"casket\\"}"} |
There was a problem hiding this comment.
The -d argument on this line ends with an extra escaped quote/brace after casket, which leaves the generated shell script with an unmatched " before curl can run. Replacing the GitHub expressions with literal values and running bash -n reproduces unexpected EOF while looking for matching '"', so every push to main/master will skip the trigger instead of notifying BoJ.
Useful? React with 👍 / 👎.
| - name: Trigger BoJ Server (Casket/ssg-mcp) | ||
| run: | | ||
| # Send a secure trigger to boj-server to build this repository | ||
| curl -X POST "http://boj-server.local:7700/cartridges/ssg-mcp/invoke" -H "Content-Type: application/json" -d "{\"repo\": \"${{ github.repository }}\", \"branch\": \"${{ github.ref_name }}\", \"engine\": \"casket\\"}"} |
There was a problem hiding this comment.
This workflow runs on ubuntu-latest, but the only endpoint it calls is http://boj-server.local:7700/.... I searched .github/, scripts/, and hooks/ for any self-hosted runner, VPN, /etc/hosts, or other network bootstrap and found no setup besides this single reference, so a normal GitHub-hosted runner has no path to that private .local host. Even after fixing the quoting bug above, pushes on main/master still will not notify the BoJ server.
Useful? React with 👍 / 👎.
1 participant
This automated PR updates your CI/CD configurations to maximize value and security.
github-actionsis monitored for updates.permissions: read-allto workflows missing explicit permissions.