fix: Is signatureChainId intentionally hardcoded to 0x66eee in sign_user_signed_action?#267
Open
KyaClaw wants to merge 1 commit intohyperliquid-dex:masterfrom
Open
fix: Is signatureChainId intentionally hardcoded to 0x66eee in sign_user_signed_action?#267KyaClaw wants to merge 1 commit intohyperliquid-dex:masterfrom
KyaClaw wants to merge 1 commit intohyperliquid-dex:masterfrom
Conversation
…ser_signed_action? Fixes hyperliquid-dex#254
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the hardcoded testnet chain ID
0x66eee(Arbitrum Sepolia) insign_user_signed_action. The comment stated thatsignatureChainIdcan be any chain, but the code forced a testnet chain ID, causing potential wallet UX confusion for mainnet users.Changes
hyperliquid/utils/signing.py: defaultsignatureChainIdto0xa4b1(Arbitrum One) for mainnet,0x66eeefor testnet, only if not already set by the caller.hyperliquid/exchange.py: computesignatureChainIddynamically based onis_mainnetin themulti_sigmethod.signatureChainIdin the action dict will have it respected.Testing
Fixes #254