Skip to content

fix: unify Exchange.market_close signature to use 'name' instead of 'coin' #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KyaClaw wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: unify Exchange.market_close signature to use 'name' instead of 'coin' #266

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions hyperliquid/exchange.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ def market_open(

def market_close(
self,
coin: str,
name: str,
sz: Optional[float] = None,
px: Optional[float] = None,
slippage: float = DEFAULT_SLIPPAGE,
Expand All @@ -253,21 +253,21 @@ def market_close(
address = self.account_address
if self.vault_address:
address = self.vault_address
dex = _get_dex(coin)
dex = _get_dex(name)
positions = self.info.user_state(address, dex)["assetPositions"]
for position in positions:
item = position["position"]
if coin != item["coin"]:
if name != item["coin"]:
continue
szi = float(item["szi"])
if not sz:
sz = abs(szi)
is_buy = True if szi < 0 else False
# Get aggressive Market Price
px = self._slippage_price(coin, is_buy, slippage, px)
px = self._slippage_price(name, is_buy, slippage, px)
# Market Order is an aggressive Limit Order IoC
return self.order(
coin,
name,
is_buy,
sz,
px,
Expand Down Expand Up @@ -1078,17 +1078,18 @@ def c_validator_unregister(self) -> Any:

def multi_sig(self, multi_sig_user, inner_action, signatures, nonce, vault_address=None):
multi_sig_user = multi_sig_user.lower()
is_mainnet = self.base_url == MAINNET_API_URL
chain_id = "0xa4b1" if is_mainnet else "0x66eee"
multi_sig_action = {
"type": "multiSig",
"signatureChainId": "0x66eee",
"signatureChainId": chain_id,
"signatures": signatures,
"payload": {
"multiSigUser": multi_sig_user,
"outerSigner": self.wallet.address.lower(),
"action": inner_action,
},
}
is_mainnet = self.base_url == MAINNET_API_URL
signature = sign_multi_sig_action(
self.wallet,
multi_sig_action,
Expand Down