[Dashboard] Fix transaction amounts/symbols for multi-token support#3813
Merged
[Dashboard] Fix transaction amounts/symbols for multi-token support#3813
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 5 Skipped Deployments
|
portuu3
requested changes
Mar 6, 2026
packages/apps/dashboard/server/src/modules/details/details.service.ts
Outdated
Show resolved
Hide resolved
packages/apps/dashboard/server/src/modules/details/details.service.ts
Outdated
Show resolved
Hide resolved
…ed components - Add in-flight token logic to avoid duplicated calls on cold starts
dnechay
reviewed
Mar 9, 2026
packages/apps/dashboard/server/src/modules/details/details.service.ts
Outdated
Show resolved
Hide resolved
packages/apps/dashboard/server/src/modules/details/details.service.ts
Outdated
Show resolved
Hide resolved
packages/apps/dashboard/server/src/modules/details/details.service.ts
Outdated
Show resolved
Hide resolved
packages/apps/dashboard/server/src/modules/details/details.spec.ts
Outdated
Show resolved
Hide resolved
…prove token metadata fetching logic
dnechay
reviewed
Mar 9, 2026
Collaborator
dnechay
left a comment
dnechay
left a comment
There was a problem hiding this comment.
lgtm overall, two questions open
packages/apps/dashboard/server/src/modules/details/details.service.ts
Outdated
Show resolved
Hide resolved
packages/apps/dashboard/server/src/modules/details/details.service.ts
Outdated
Show resolved
Hide resolved
dnechay
previously approved these changes
Mar 9, 2026
packages/apps/dashboard/server/src/modules/details/details.service.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Dmitry Nechay <dmitry@hmt.ai>
dnechay
approved these changes
Mar 10, 2026
portuu3
approved these changes
Mar 10, 2026
github-project-automation
bot
moved this from In Review
to Done
in Core tech - 2026 (H1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue tracking
None
Context behind the change
Transactions were always treated as HMT (18 decimals). Multi-token values (e.g. USDC 6 decimals) were displayed incorrectly.
Now:
symbol(not hardcoded HMT) and shows - whenamountis 0 andsymbolis missing.formatTokenAmount.How has this been tested?
Deployed dashboard locally.
Ran unit tests.
Release plan
Deploy new dashboard backend and frontend
Potential risks; What to monitor; Rollback plan
None