Skip to content

Comments

[Snyk] Fix for 2 vulnerabilities#451

Open
q1blue wants to merge 2 commits intonextfrom
snyk-fix-4b7715e90b8759712c32e05b4f77a69f
Open

[Snyk] Fix for 2 vulnerabilities#451
q1blue wants to merge 2 commits intonextfrom
snyk-fix-4b7715e90b8759712c32e05b4f77a69f

Conversation

@q1blue
Copy link

@q1blue q1blue commented Feb 16, 2026

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • code/frameworks/react-webpack5/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-AJV-15274295
  157  
medium severity Allocation of Resources Without Limits or Throttling
SNYK-JS-QS-15268416
  62  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Allocation of Resources Without Limits or Throttling

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, focuses on enhancing the security of the react-webpack5 framework by resolving two identified vulnerabilities. It achieves this by upgrading specific Storybook dependencies to their patched versions, thereby mitigating potential risks related to Regular Expression Denial of Service and resource allocation issues.

Highlights

  • Security Vulnerability Fixes: Addressed two critical security vulnerabilities, Regular Expression Denial of Service (ReDoS) and Allocation of Resources Without Limits or Throttling, identified by Snyk.
  • Dependency Version Upgrades: Updated @storybook/builder-webpack5 to 7.1.0 and @storybook/preset-react-webpack to 7.0.0 in code/frameworks/react-webpack5/package.json.
Changelog
  • code/frameworks/react-webpack5/package.json
    • Upgraded @storybook/builder-webpack5 from workspace:* to 7.1.0.
    • Upgraded @storybook/preset-react-webpack from workspace:* to 7.0.0.
Activity
  • This pull request was automatically created by Snyk to fix identified vulnerabilities.
  • A warning was issued regarding the yarn.lock file, indicating it failed to update and requires manual intervention.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, aims to fix two vulnerabilities by updating dependencies. However, the proposed changes are incorrect for this monorepo setup. It downgrades @storybook/builder-webpack5 and @storybook/preset-react-webpack to older major versions instead of using the consistent versions from the workspace via workspace:*. This will very likely break the project. I've added a comment with a suggestion to revert this change and pointed to a more appropriate way to fix the underlying security vulnerabilities, such as using yarn's resolutions feature.

Comment on lines +50 to +51
"@storybook/builder-webpack5": "7.1.0",
"@storybook/preset-react-webpack": "7.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change downgrades @storybook/builder-webpack5 and @storybook/preset-react-webpack from using the current workspace version to older, fixed major versions. In a monorepo setup, this is highly likely to cause build failures or runtime issues due to API incompatibilities between packages. The workspace:* protocol is used to ensure all packages in the monorepo are using consistent versions from within the workspace.

Instead of pinning to old major versions, the correct approach is to keep workspace:* and address the underlying vulnerabilities. This might involve using resolutions in the root package.json (for yarn) to force a safe version of the transitive dependencies (ajv and qs).

    "@storybook/builder-webpack5": "workspace:*",
    "@storybook/preset-react-webpack": "workspace:*"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants