Conversation
…ities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-AJV-15274295 - https://snyk.io/vuln/SNYK-JS-QS-15268416
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, focuses on enhancing the security of the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request, automatically generated by Snyk, aims to fix two vulnerabilities by updating dependencies. However, the proposed changes are incorrect for this monorepo setup. It downgrades @storybook/builder-webpack5 and @storybook/preset-react-webpack to older major versions instead of using the consistent versions from the workspace via workspace:*. This will very likely break the project. I've added a comment with a suggestion to revert this change and pointed to a more appropriate way to fix the underlying security vulnerabilities, such as using yarn's resolutions feature.
| "@storybook/builder-webpack5": "7.1.0", | ||
| "@storybook/preset-react-webpack": "7.0.0", |
There was a problem hiding this comment.
This change downgrades @storybook/builder-webpack5 and @storybook/preset-react-webpack from using the current workspace version to older, fixed major versions. In a monorepo setup, this is highly likely to cause build failures or runtime issues due to API incompatibilities between packages. The workspace:* protocol is used to ensure all packages in the monorepo are using consistent versions from within the workspace.
Instead of pinning to old major versions, the correct approach is to keep workspace:* and address the underlying vulnerabilities. This might involve using resolutions in the root package.json (for yarn) to force a safe version of the transitive dependencies (ajv and qs).
"@storybook/builder-webpack5": "workspace:*",
"@storybook/preset-react-webpack": "workspace:*"…ities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-AJV-15274295 - https://snyk.io/vuln/SNYK-JS-QS-15268416
Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
code/frameworks/react-webpack5/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-AJV-15274295
SNYK-JS-QS-15268416
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)
🦉 Allocation of Resources Without Limits or Throttling