Skip to content

[Snyk] Fix for 1 vulnerabilities#449

Open
q1blue wants to merge 1 commit intonextfrom
snyk-fix-7ff2b57a5d52b80ac9ec1506bb151bf9
Open

[Snyk] Fix for 1 vulnerabilities#449
q1blue wants to merge 1 commit intonextfrom
snyk-fix-7ff2b57a5d52b80ac9ec1506bb151bf9

Conversation

@q1blue
Copy link

@q1blue q1blue commented Feb 15, 2026

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • code/presets/react-webpack/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-AJV-15274295
  157  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the project's security posture by resolving a critical vulnerability. It primarily involves updating key development dependencies to their patched versions, ensuring the application is protected against known security risks.

Highlights

  • Security Vulnerability Fix: This PR addresses a high-severity Regular Expression Denial of Service (ReDoS) vulnerability (SNYK-JS-AJV-15274295) found in the project's yarn dependencies.
  • Dependency Updates: The @storybook/core-webpack dependency was updated from workspace:* to 7.0.0, and webpack was updated from 5 to 5.98.0 in code/presets/react-webpack/package.json.
  • Manual Intervention Required: The yarn.lock file was not automatically updated, requiring manual intervention, especially for projects utilizing Yarn's zero-installs feature.
Changelog
  • code/presets/react-webpack/package.json
    • Updated @storybook/core-webpack dependency from workspace:* to 7.0.0.
    • Updated webpack dependency from 5 to 5.98.0.
Activity
  • Snyk automatically created this pull request to fix identified vulnerabilities.
  • Snyk detected one high-severity Regular Expression Denial of Service (ReDoS) vulnerability (SNYK-JS-AJV-15274295).
  • The package.json file was modified to update relevant dependencies.
  • A warning was issued indicating that the yarn.lock file could not be updated automatically, requiring manual action.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, aims to fix a ReDoS vulnerability by upgrading dependencies. While the upgrade of webpack seems correct, the change to @storybook/core-webpack is problematic. It replaces a workspace dependency with a hardcoded, older major version, which is likely to break the project's monorepo structure. I've added a critical comment suggesting to revert this specific change.

},
"dependencies": {
"@storybook/core-webpack": "workspace:*",
"@storybook/core-webpack": "7.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change downgrades @storybook/core-webpack from a workspace dependency (which would resolve to the in-repo version 8.3.0-beta.3) to a fixed, older major version 7.0.0. This breaks the monorepo's workspace setup and is likely to cause version mismatches and runtime errors, as Storybook packages are tightly coupled. It is highly recommended to revert this change and keep using workspace:* to ensure dependency consistency within the monorepo. The vulnerability fix is likely addressed by the webpack dependency upgrade in this same file.

Suggested change
"@storybook/core-webpack": "7.0.0",
"@storybook/core-webpack": "workspace:*",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants