Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-AJV-15274295 - https://snyk.io/vuln/SNYK-JS-QS-15268416
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to improve the project's security by resolving two identified vulnerabilities: a high-severity Regular Expression Denial of Service (ReDoS) and a medium-severity resource allocation issue. This is achieved by upgrading and pinning specific dependencies within the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request from Snyk aims to fix two security vulnerabilities by updating dependencies. While the update for @pmmmwh/react-refresh-webpack-plugin is acceptable, the changes for @storybook/builder-webpack5 and @storybook/preset-react-webpack are critically flawed. They replace monorepo workspace dependencies (workspace:*) with specific, older major versions from the public registry. This is a significant downgrade and will almost certainly break the build in a monorepo context. I have added a critical review comment suggesting to revert these changes. The security vulnerabilities should be addressed through alternative means, such as using resolutions in package.json to pin the vulnerable transitive dependencies to safe versions.
| "@storybook/builder-webpack5": "7.1.0", | ||
| "@storybook/preset-react-webpack": "7.0.0", |
There was a problem hiding this comment.
These changes incorrectly replace workspace-local dependencies (workspace:*) with fixed, older major versions from the public registry. This package is part of a monorepo, and these dependencies should resolve to other packages within the same workspace (which are on version 8.3.0-beta.3). Downgrading to major versions 7.1.0 and 7.0.0 will introduce breaking changes and cause build or runtime failures.
While this was likely done to resolve a security vulnerability, this approach is incorrect for a monorepo setup. The vulnerabilities should be addressed by other means, such as using resolutions in the root package.json to force a safe version of the transitive dependency, without breaking the monorepo structure.
"@storybook/builder-webpack5": "workspace:*",
"@storybook/preset-react-webpack": "workspace:*"The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-AJV-15274295 - https://snyk.io/vuln/SNYK-JS-QS-15268416
Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
code/frameworks/nextjs/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-AJV-15274295
SNYK-JS-QS-15268416
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)
🦉 Allocation of Resources Without Limits or Throttling