Skip to content

Comments

[Snyk] Fix for 2 vulnerabilities#448

Open
q1blue wants to merge 2 commits intonextfrom
snyk-fix-4e575df2c3a4cf7ef93d3483dc4b2dfe
Open

[Snyk] Fix for 2 vulnerabilities#448
q1blue wants to merge 2 commits intonextfrom
snyk-fix-4e575df2c3a4cf7ef93d3483dc4b2dfe

Conversation

@q1blue
Copy link

@q1blue q1blue commented Feb 15, 2026

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • code/frameworks/nextjs/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-AJV-15274295
  157  
medium severity Allocation of Resources Without Limits or Throttling
SNYK-JS-QS-15268416
  62  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Allocation of Resources Without Limits or Throttling

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to improve the project's security by resolving two identified vulnerabilities: a high-severity Regular Expression Denial of Service (ReDoS) and a medium-severity resource allocation issue. This is achieved by upgrading and pinning specific dependencies within the nextjs framework's package.json.

Highlights

  • Vulnerability Resolution: Addressed a high-severity Regular Expression Denial of Service (ReDoS) vulnerability (SNYK-JS-AJV-15274295) and a medium-severity Allocation of Resources Without Limits or Throttling vulnerability (SNYK-JS-QS-15268416).
  • Dependency Version Updates: Upgraded the @pmmmwh/react-refresh-webpack-plugin dependency from 0.5.11 to 0.5.15.
  • Storybook Dependency Pinning: Changed @storybook/builder-webpack5 and @storybook/preset-react-webpack from workspace:* to specific versions 7.1.0 and 7.0.0 respectively, likely to resolve transitive vulnerabilities.
  • Manual yarn.lock Update Required: The yarn.lock file was not automatically updated and requires manual intervention to ensure correct dependency resolution, especially for users leveraging Yarn's zero-install feature.
Changelog
  • code/frameworks/nextjs/package.json
    • Upgraded @pmmmwh/react-refresh-webpack-plugin to ^0.5.15.
    • Updated @storybook/builder-webpack5 from workspace:* to 7.1.0.
    • Updated @storybook/preset-react-webpack from workspace:* to 7.0.0.
Activity
  • Snyk automatically created this pull request to fix 2 identified vulnerabilities.
  • Snyk reported a failure to update the yarn.lock file, indicating a need for manual update.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request from Snyk aims to fix two security vulnerabilities by updating dependencies. While the update for @pmmmwh/react-refresh-webpack-plugin is acceptable, the changes for @storybook/builder-webpack5 and @storybook/preset-react-webpack are critically flawed. They replace monorepo workspace dependencies (workspace:*) with specific, older major versions from the public registry. This is a significant downgrade and will almost certainly break the build in a monorepo context. I have added a critical review comment suggesting to revert these changes. The security vulnerabilities should be addressed through alternative means, such as using resolutions in package.json to pin the vulnerable transitive dependencies to safe versions.

Comment on lines +142 to +143
"@storybook/builder-webpack5": "7.1.0",
"@storybook/preset-react-webpack": "7.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes incorrectly replace workspace-local dependencies (workspace:*) with fixed, older major versions from the public registry. This package is part of a monorepo, and these dependencies should resolve to other packages within the same workspace (which are on version 8.3.0-beta.3). Downgrading to major versions 7.1.0 and 7.0.0 will introduce breaking changes and cause build or runtime failures.

While this was likely done to resolve a security vulnerability, this approach is incorrect for a monorepo setup. The vulnerabilities should be addressed by other means, such as using resolutions in the root package.json to force a safe version of the transitive dependency, without breaking the monorepo structure.

    "@storybook/builder-webpack5": "workspace:*",
    "@storybook/preset-react-webpack": "workspace:*"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants