Skip to content

Comments

[Snyk] Security upgrade @storybook/core-webpack from 0.0.0-use.local to 7.0.0#447

Open
q1blue wants to merge 2 commits intonextfrom
snyk-fix-d117b737dbb4060092f7f5e73a875ad9
Open

[Snyk] Security upgrade @storybook/core-webpack from 0.0.0-use.local to 7.0.0#447
q1blue wants to merge 2 commits intonextfrom
snyk-fix-d117b737dbb4060092f7f5e73a875ad9

Conversation

@q1blue
Copy link

@q1blue q1blue commented Feb 15, 2026

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • code/presets/svelte-webpack/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-AJV-15274295
  157  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates a critical security update by upgrading a core dependency to mitigate a known vulnerability. The change ensures that the project uses a more secure version of @storybook/core-webpack, protecting against potential Regular Expression Denial of Service attacks. While the dependency update is straightforward, users of Yarn's zero-installs feature will need to manually update their .yarn/cache directory, as the yarn.lock file was not automatically updated.

Highlights

  • Security Upgrade: Upgraded the @storybook/core-webpack dependency from workspace:* to 7.0.0 in code/presets/svelte-webpack/package.json to remediate a high-severity Regular Expression Denial of Service (ReDoS) vulnerability (SNYK-JS-AJV-15274295).
  • Automated Fix: This pull request was automatically generated by Snyk to address identified security vulnerabilities.
Changelog
  • code/presets/svelte-webpack/package.json
    • Updated the @storybook/core-webpack dependency version from workspace:* to 7.0.0.
Activity
  • Snyk automatically created this PR to fix 1 vulnerability in the yarn dependencies.
  • A warning was noted that the yarn.lock file failed to update and requires manual intervention.
  • Snyk provided details on the Regular Expression Denial of Service (ReDoS) vulnerability (SNYK-JS-AJV-15274295) with a score of 157.
  • Snyk included links to a project report, PR template customization, project settings, and documentation on upgrade logic.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, attempts to fix a security vulnerability by upgrading @storybook/core-webpack. However, the proposed change of pinning the version to 7.0.0 is incorrect for this monorepo environment. The project uses yarn workspaces, and the workspace:* specifier ensures that the local version of the package is used. Changing this to a fixed version will break the monorepo's dependency linking, likely causing a downgrade and build issues. The change should be reverted, and the vulnerability should be assessed against the current version of @storybook/core-webpack within the workspace, which is 8.3.0-beta.3.

},
"dependencies": {
"@storybook/core-webpack": "workspace:*",
"@storybook/core-webpack": "7.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly replaces a monorepo workspace dependency with a fixed version. The workspace:* protocol is used to ensure that packages within this monorepo are linked together. By changing this to 7.0.0, you are forcing this package to use a specific version from the npm registry, which is likely older than the version in the workspace (8.3.0-beta.3) and will break the internal dependency structure of the monorepo. This change should be reverted.

Suggested change
"@storybook/core-webpack": "7.0.0",
"@storybook/core-webpack": "workspace:*",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants