Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
203 changes: 109 additions & 94 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"format": "prettier '**/*' --write --ignore-unknown"
},
"dependencies": {
"next": "latest",
"next": "12.3.7",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

While pinning the next dependency to a specific version is a great improvement over using latest for build reproducibility, the chosen version 12.3.7 is concerning.

  1. Non-standard Version: Version 12.3.7 does not appear to be a public release on npm. This could cause npm install to fail for developers and in CI/CD environments if they don't have access to the private registry where this version might be hosted.
  2. Outdated Version: next.js has evolved significantly. Sticking to an old version means missing out on important performance improvements, features, and security patches that are not covered by this specific upgrade.
  3. Inconsistent Dependencies: The package-lock.json shows that while next is updated to 12.3.7, its @next/swc-* dependencies are only updated to 12.3.4. This version mismatch within the same framework can be a source of subtle bugs.

I recommend upgrading to a more recent, stable version of next. If a major upgrade to v13 or v14 is not feasible right now, please consider at least upgrading to the latest v12 release, which is 12.3.4.

Suggested change
"next": "12.3.7",
"next": "^12.3.4",

"react": "17.0.2",
"react-dom": "17.0.2"
},
Expand Down
Loading