feat: Transition to injection and handle user fallback#75
Merged
TDannhauer merged 1 commit intoFRAMEWORK_6_0from Mar 31, 2026
Merged
Conversation
horde/ActiveSync#22 originally had an architecture violation, calling into Horde Registry and using globals from library level This change instead moves all user detection logic to an overloaded driver->getUser method in horde/core level. This keeps the activesync library clean of horde glue. As a side goal we inject the registry and the modern PSR-7 request from the factory. Horde_ActiveSync normally uses the homegrown Horde_Controller_Request object but we can wrap the PSR-7 object into a Horde_Controller_Request (Psr7Wrapper). So going forward we will step by step migrate to PSR-7 standard. The original PR's fallback logic is kept (base getUser implementation, get "user" parameter from request, fall back to authenticated horde user)
ralflang
added a commit
to horde/ActiveSync
that referenced
this pull request
Mar 31, 2026
This was referenced Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
horde/ActiveSync#22 originally had an architecture violation, calling into Horde Registry and using globals from library level
This change instead moves all user detection logic to an overloaded driver->getUser method in horde/core level.
This keeps the activesync library clean of horde glue.
As a side goal we inject the registry and the modern PSR-7 request from the factory.
Horde_ActiveSync normally uses the homegrown Horde_Controller_Request object but we can wrap the PSR-7 object into a Horde_Controller_Request (Psr7Wrapper).
So going forward we will step by step migrate to PSR-7 standard.
The original PR's fallback logic is kept (base getUser implementation, get "user" parameter from request, fall back to authenticated horde user)