Skip to content

fix(portal): handle empty custom_headers in create destination flow #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexluong merged 1 commit into from
Feb 20, 2026
Merged

fix(portal): handle empty custom_headers in create destination flow #708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions internal/portal/src/scenes/CreateDestination/CreateDestination.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,11 +315,24 @@ export default function CreateDestination() {
topics: topics,
...(filter && Object.keys(filter).length > 0 ? { filter } : {}),
config: Object.fromEntries(
Object.entries(values).filter(([key]) =>
destination_type?.config_fields.some(
(field) => field.key === key,
),
),
Object.entries(values)
.filter(([key]) =>
destination_type?.config_fields.some(
(field) => field.key === key,
),
)
.map(([key, value]) => {
let configValue = String(value);
// Webhook custom_headers must have at least one header or be null/empty
if (
destination_type?.type === "webhook" &&
key === "custom_headers" &&
(configValue === "{}" || configValue === "")
) {
configValue = "";
}
return [key, configValue];
}),
),
credentials: Object.fromEntries(
Object.entries(values).filter(([key]) =>
Expand Down
Loading