Fix Singapore 2026 public holiday dates#311
Fix Singapore 2026 public holiday dates#311StephenMF-beep wants to merge 1 commit intoholidays:masterfrom
Conversation
|
Changed the Singapore file to have the correct dates for Deepavali 2026 date from Oct 8 to Nov 8 |
|
Hello! Can you please rebase? There are a lot of unrelated changes. Then I'll review and merge. |
03dc484 to
b9de102
Compare
thanks for letting me know. I have rebased and pushed this branch back in to github. |
|
@StephenMF-beep I think something went wrong after rebase, please make sure you have only your changes |
- Fix Deepavali 2026 date from Oct 8 to Nov 8 - Fix Hari Raya Puasa 2026 date from Mar 20 to Mar 21 - Add methods for Chinese New Year, Deepavali, Hari Raya Puasa/Haji, Vesak Day Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
b9de102 to
560a73f
Compare
|
Thank you for rebasing! I added a new job that tests against the downstream ruby gem and it seems to have caught something. Let me take a closer look and we can find out what needs to be updated. |
|
Oh! It says it in the error, it is just buffered weird. I am going to try to address how it is shown but there is a problem with the format of the methods you added: The key of 'source' should instead be 'ruby'. I had this wild idea that we would potentially have other languages that could do their own functions and so we want to be specific, even though we only do 'ruby' right now. Replace the instances of 'source' with 'ruby' and then push again and let's see what happens. |
Summary
Test plan
bundle exec ruby lib/validation/run.rb— Successbundle exec rspec— 50 examples, 0 failures🤖 Generated with Claude Code