Open
Conversation
… objects, tooltip handling, tabix input handling)
pkerpedjiev
reviewed
Jan 22, 2025
pkerpedjiev
reviewed
Jan 22, 2025
pkerpedjiev
approved these changes
Jan 31, 2025
Member
|
Looks like the build is failing because there's no package-lock.json file? |
Contributor
Author
|
I apologize but I'm a little confused about this requirement. I'm happy to add what I have locally, but is this file typically committed to source control? I thought this was specific to the end user's environment (and what packages are available on the host platform at the time |
Member
|
We do typically check this file in to make sure that when we run tests and deploy the exact version dependencies are used that were used when developing the component. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR for the HiGlass
higlass-transcriptsplugin includes Pixi resource memory leak fixes, PNG/SVG export fixes, more graceful error handling for null Pixi objects, and feature enhancements for mouseover tooltips and tabix input handling. This also integrates fixes that have been merged into the upstream (base) HiGlass repository in the master branch (currently post v0.3.8).