ROG Ally: Hall effect interference correction#307
Open
SomeoneIsWorking wants to merge 1 commit intohhd-dev:masterfrom
Open
ROG Ally: Hall effect interference correction#307SomeoneIsWorking wants to merge 1 commit intohhd-dev:masterfrom
SomeoneIsWorking wants to merge 1 commit intohhd-dev:masterfrom
Conversation
SomeoneIsWorking
changed the title
SomeoneIsWorking
force-pushed
the
master
branch
from
0e3288e to
60c85ea
Compare
Author
|
I think the "Mode" setting doesn't persist, I need to do another test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Software correction option for hall effect LT-LS interference (and some slight RS correction too)
What this does is it basically applies a correction to LS X axis based on LT value but with other slight corrections too.
Has 3 modes: Disabled (Default), Default (haha), Manual (with sliders)
This took me a lot of trial and error but I think I got it right.
Yes this also has its own deadzone configs because it was easier to make a custom one for this purpose.
Also yes the code says "rt" but for some reason ev["code"] == "rt" is the LT value here... I couldn't figure out why.