Skip to content

network: fall back to static configuration#2334

Open
cagatay-y wants to merge 2 commits intohermit-os:mainfrom
cagatay-y:dhcp-fallback
Open

network: fall back to static configuration#2334
cagatay-y wants to merge 2 commits intohermit-os:mainfrom
cagatay-y:dhcp-fallback

Conversation

@cagatay-y
Copy link
Contributor

No description provided.

If the DHCP feature is left enabled, the network interface does not use
the provided IP. This is a problem especially as the feature is enabled
by default.
This signals to the kernel that it should use the static IP even if the
DHCP feature is enabled. Note that if a DHCP lease is acquired it will
replace the static configuration. However, this should not happen with
our TAP configuration.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Results

Details
Benchmark Current: 7f67e6a Previous: fdad7b9 Performance Ratio
startup_benchmark Build Time 90.11 s 99.53 s 0.91
startup_benchmark File Size 0.75 MB 0.75 MB 1.00
Startup Time - 1 core 0.95 s (±0.03 s) 0.97 s (±0.03 s) 0.98
Startup Time - 2 cores 0.96 s (±0.03 s) 1.04 s (±0.04 s) 0.92
Startup Time - 4 cores 0.95 s (±0.03 s) 1.05 s (±0.03 s) 0.91
multithreaded_benchmark Build Time 86.29 s 96.40 s 0.90
multithreaded_benchmark File Size 0.86 MB 0.86 MB 1.00
Multithreaded Pi Efficiency - 2 Threads 90.26 % (±10.51 %) 90.17 % (±10.02 %) 1.00
Multithreaded Pi Efficiency - 4 Threads 45.09 % (±5.13 %) 44.84 % (±3.27 %) 1.01
Multithreaded Pi Efficiency - 8 Threads 25.80 % (±2.20 %) 25.76 % (±1.71 %) 1.00
micro_benchmarks Build Time 94.12 s 112.36 s 0.84
micro_benchmarks File Size 0.86 MB 0.86 MB 1.00
Scheduling time - 1 thread 64.26 ticks (±3.25 ticks) 71.35 ticks (±5.90 ticks) 0.90
Scheduling time - 2 threads 34.43 ticks (±3.16 ticks) 38.38 ticks (±4.04 ticks) 0.90
Micro - Time for syscall (getpid) 2.91 ticks (±0.21 ticks) 3.33 ticks (±0.37 ticks) 0.87
Memcpy speed - (built_in) block size 4096 67162.71 MByte/s (±47904.05 MByte/s) 59141.93 MByte/s (±42155.36 MByte/s) 1.14
Memcpy speed - (built_in) block size 1048576 29713.79 MByte/s (±24598.91 MByte/s) 30401.31 MByte/s (±25552.10 MByte/s) 0.98
Memcpy speed - (built_in) block size 16777216 28188.43 MByte/s (±23469.35 MByte/s) 18341.16 MByte/s (±15866.43 MByte/s) 1.54
Memset speed - (built_in) block size 4096 67643.82 MByte/s (±48222.67 MByte/s) 59854.14 MByte/s (±42637.78 MByte/s) 1.13
Memset speed - (built_in) block size 1048576 30411.24 MByte/s (±25009.56 MByte/s) 31197.32 MByte/s (±25968.12 MByte/s) 0.97
Memset speed - (built_in) block size 16777216 28943.54 MByte/s (±23888.75 MByte/s) 19097.59 MByte/s (±16493.26 MByte/s) 1.52
Memcpy speed - (rust) block size 4096 60913.73 MByte/s (±44967.91 MByte/s) 53053.28 MByte/s (±39154.81 MByte/s) 1.15
Memcpy speed - (rust) block size 1048576 29643.05 MByte/s (±24566.94 MByte/s) 30466.90 MByte/s (±25665.47 MByte/s) 0.97
Memcpy speed - (rust) block size 16777216 28261.22 MByte/s (±23568.56 MByte/s) 18261.97 MByte/s (±15789.67 MByte/s) 1.55
Memset speed - (rust) block size 4096 61597.15 MByte/s (±45398.69 MByte/s) 53807.69 MByte/s (±39617.33 MByte/s) 1.14
Memset speed - (rust) block size 1048576 30413.12 MByte/s (±24987.17 MByte/s) 31246.57 MByte/s (±26099.44 MByte/s) 0.97
Memset speed - (rust) block size 16777216 29030.31 MByte/s (±24005.15 MByte/s) 18401.39 MByte/s (±15837.36 MByte/s) 1.58
alloc_benchmarks Build Time 91.57 s 113.86 s 0.80
alloc_benchmarks File Size 0.82 MB 0.82 MB 1.00
Allocations - Allocation success 100.00 % 100.00 % 1
Allocations - Deallocation success 100.00 % 100.00 % 1
Allocations - Pre-fail Allocations 100.00 % 100.00 % 1
Allocations - Average Allocation time 14101.24 Ticks (±336.50 Ticks) 14598.49 Ticks (±323.80 Ticks) 0.97
Allocations - Average Allocation time (no fail) 14101.24 Ticks (±336.50 Ticks) 14598.49 Ticks (±323.80 Ticks) 0.97
Allocations - Average Deallocation time 2206.23 Ticks (±1934.86 Ticks) 1496.91 Ticks (±1132.41 Ticks) 1.47
mutex_benchmark Build Time 92.20 s 108.58 s 0.85
mutex_benchmark File Size 0.86 MB 0.86 MB 1.00
Mutex Stress Test Average Time per Iteration - 1 Threads 13.20 ns (±0.66 ns) 13.76 ns (±0.88 ns) 0.96
Mutex Stress Test Average Time per Iteration - 2 Threads 24.24 ns (±17.05 ns) 22.58 ns (±13.74 ns) 1.07

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant