Fix "Invalid event" error when server sent heartbeats#438
Open
tribela wants to merge 2 commits intohalcy:masterfrom
Open
Fix "Invalid event" error when server sent heartbeats#438tribela wants to merge 2 commits intohalcy:masterfrom
tribela wants to merge 2 commits intohalcy:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #438 +/- ##
=======================================
Coverage 88.88% 88.88%
=======================================
Files 35 35
Lines 4821 4823 +2
=======================================
+ Hits 4285 4287 +2
Misses 536 536 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Oh, you even added a test! Thank you, this is fantastic. Merging next time I work on this, which now that our Revision invite is out, should be soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will fix #434