Remove Cache::SetupSocialProofJob and Cache::UsageSocialProofJob#1321
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes unused “social proof” cache jobs and the associated Svelte/UI plumbing from the home page, simplifying the cache warmup/cron configuration and the Inertia props surface.
Changes:
- Removed
Cache::SetupSocialProofJobandCache::UsageSocialProofJob(and their cron + warmup hooks). - Deleted the signed-in social-proof UI component and removed related props/types from the frontend.
- Simplified
StaticPagesController#indexand signed-in props by dropping social proof calculation and payload fields.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/tasks/cache.rake | Removes social proof jobs from the cache warmup list. |
| config/initializers/good_job.rb | Removes cron entries for the deleted social proof cache jobs. |
| app/jobs/cache/usage_social_proof_job.rb | Deletes unused cache job implementation. |
| app/jobs/cache/setup_social_proof_job.rb | Deletes unused cache job implementation. |
| app/javascript/types/index.ts | Removes SocialProofUser type that is no longer referenced. |
| app/javascript/pages/Home/signedIn/SocialProofUsers.svelte | Deletes unused UI component for social proof avatars/message. |
| app/javascript/pages/Home/signedIn/SetupNotice.svelte | Removes social proof props/import and renders only the setup CTA. |
| app/javascript/pages/Home/SignedIn.svelte | Removes social proof props/types and stops passing them to SetupNotice. |
| app/controllers/static_pages_controller.rb | Stops computing/passing social proof props and removes unused cache job calls. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Greptile SummaryThis PR removes two unused background cache jobs —
Confidence Score: 5/5Safe to merge — this is a complete, self-contained removal with no dangling references. Every layer of the feature (backend jobs, cron config, rake tasks, Svelte components, TypeScript types, and controller props) is removed consistently. A full-codebase grep confirms no orphaned references remain. The UsageSocialProofJob result was already a no-op in production since it was never passed to the frontend, so its removal has no user-visible effect. The SetupSocialProofJob removal changes the setup notice UI, which the PR author intentionally accepted. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
subgraph BEFORE["Before (removed)"]
A1["GoodJob cron (every minute)"] --> B1["Cache::SetupSocialProofJob"]
A1 --> B2["Cache::UsageSocialProofJob"]
B1 --> C1["@ssp_message, @ssp_users_recent, @ssp_users_size"]
B2 --> C2["@usage_social_proof (unused)"]
C1 --> D1["signed_in_props → SetupNotice → SocialProofUsers.svelte"]
C2 -. "never used" .-> X["❌ dropped"]
end
subgraph AFTER["After"]
A2["GoodJob cron (every minute)"] --> B3["Cache::HomeStatsJob"]
A2 --> B4["Cache::ActiveProjectsJob"]
B3 --> C3["signed_out_props"]
D2["signed_in_props → SetupNotice (no social proof)"]
end
Reviews (1): Last reviewed commit: "Remove `Cache::SetupSocialProofJob` and ..." | Re-trigger Greptile |
Summary of the problem
Describe your changes
Removes the social proof jobs + Svelte code.
Screenshots / Media