Add organizer summary emails by sampoder · Pull Request #194 · hackclub/hackathons-backend

sampoder · 2023-08-22T08:06:48Z

Fixes #192, I feel like the copy is missing something...

garyhtou · 2023-08-22T08:17:26Z

I'll review this tmrw! I can retroactively send these organizer summaries after the first digest batch is sent

sampoder · 2023-08-22T08:20:06Z

Sounds like a plan! From Sam

On Tue, Aug 22, 2023 at 1:17 AM Gary Tou ***@***.***> wrote: I'll review this tmrw! I can retroactively send these organizer summaries after the first digest batch is sent — Reply to this email directly, view it on GitHub <#194 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJP3VREDTCKGUDDKAUYSONTXWRTKBANCNFSM6AAAAAA3ZQD7HA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

northeastprince · 2023-08-22T10:06:14Z

Was that a rhyme? 😆

sampoder · 2023-08-22T17:56:40Z

didn't intend it but sure... that's my email signature for primary school lol

garyhtou

thanks for working on this Sam! the logic is great. here's what I propose to reorganize this code a little bit:

In the SendDigestsJob, call a new Job called SendOrganizerSummariesJob and pass in sent_digests.

In SendOrganizerSummariesJob, copy in the code that you currently have in DigestMailer#organizer_summary. Change the each loop to call DigestMailer#organizer_summary and pass it a list of sent_digests specific to that hackathon.

In DigestMailer#organizer_summary, take in the list of sent_digests for that hackathon. Compute the count, and call the mail method

app/views/hackathons/digest_mailer/organizer_summary.html.erb

app/mailers/hackathons/digest_mailer.rb

Co-authored-by: Gary Tou <gary@garytou.com>

sampoder · 2023-08-22T22:40:51Z

@garyhtou thanks for the review! hopefully I understood you correctly here, just pushed the restructure

app/jobs/hackathons/send_organizer_summaries_job.rb

Co-authored-by: Matt Almeida <matt7@hey.com>

app/mailers/hackathons/digest_mailer.rb

app/views/hackathons/digest_mailer/organizer_summary.html.erb

app/views/hackathons/digest_mailer/organizer_summary.text.erb

app/mailers/hackathons/digest_mailer.rb

app/jobs/hackathons/send_organizer_summaries_job.rb

Co-authored-by: Matt Almeida <matt7@hey.com>

app/jobs/hackathons/send_organizer_summaries_job.rb

test/mailers/hackathons/organizer_summary_test.rb

northeastprince · 2023-12-06T18:16:10Z

test/mailers/hackathons/organizer_summary_test.rb

@@ -0,0 +1,17 @@
+require "test_helper"


I would incorporate this test into the existing DigestMailerTest to match the mailer itself.

Could you help me with that? I'm not quite sure what you mean, sorry

Organizer summaries are in the existing DigestMailer, so use the existing test file as well.

Oh I gotcha

northeastprince · 2023-12-06T21:06:10Z

I'd like to take care of #190 before we merge this.

Co-authored-by: Matt Almeida <matt7@hey.com>

app/jobs/hackathons/send_organizer_summaries_job.rb

northeastprince · 2023-12-25T02:44:09Z

test/mailers/hackathons/organizer_summary_test.rb

@@ -0,0 +1,17 @@
+require "test_helper"


Organizer summaries are in the existing DigestMailer, so use the existing test file as well.

app/jobs/hackathons/digests_delivery_job.rb

Co-authored-by: Matt Almeida <matt7@hey.com>

sampoder added 9 commits August 22, 2023 00:58

Update digest_mailer.rb

07ea523

Create organizer-summary.html.erb

3ac0e14

Rename organizer-summary.html.erb to organizer_summary.html.erb

7e08a8c

Update digest_mailer.rb

325a72e

Update organizer_summary.html.erb

b399e35

Update digest_mailer.rb

2d5d748

Update organizer_summary.html.erb

5e4c9f0

Update digest_mailer.rb

28474c9

Update digest_mailer.rb

994b8e6

garyhtou requested changes Aug 22, 2023

View reviewed changes

app/views/hackathons/digest_mailer/organizer_summary.html.erb Show resolved Hide resolved

app/views/hackathons/digest_mailer/organizer_summary.html.erb Outdated Show resolved Hide resolved

app/mailers/hackathons/digest_mailer.rb Outdated Show resolved Hide resolved

garyhtou reviewed Aug 22, 2023

View reviewed changes

app/mailers/hackathons/digest_mailer.rb Outdated Show resolved Hide resolved

sampoder and others added 6 commits August 22, 2023 13:50

Update digest_mailer.rb

e1e15bf

Update app/mailers/hackathons/digest_mailer.rb

19f3094

Co-authored-by: Gary Tou <gary@garytou.com>

Update app/views/hackathons/digest_mailer/organizer_summary.html.erb

a23ec86

Create organizer_summary.text.erb

c8bf0d4

Restructure Post-Review

4c25f3a

Standard

7e803ac

sampoder added 5 commits August 22, 2023 15:41

Update send_organizer_summaries_job.rb

c633124

Merge branch 'main' into organizer-summary

f08d496

Update send_organizer_summaries_job.rb

8c594d4

Merge branch 'main' into organizer-summary

1f94a11

Merge branch 'main' into organizer-summary

af8f7ed

northeastprince reviewed Nov 11, 2023

View reviewed changes

app/jobs/hackathons/send_organizer_summaries_job.rb Outdated Show resolved Hide resolved

Update send_organizer_summaries_job.rb

728b784

Co-authored-by: Matt Almeida <matt7@hey.com>

northeastprince reviewed Dec 6, 2023

View reviewed changes

sampoder and others added 5 commits December 6, 2023 08:52

Update app/mailers/hackathons/digest_mailer.rb

31243bc

Co-authored-by: Matt Almeida <matt7@hey.com>

Update app/views/hackathons/digest_mailer/organizer_summary.html.erb

331ec67

Co-authored-by: Matt Almeida <matt7@hey.com>

Update app/views/hackathons/digest_mailer/organizer_summary.text.erb

1b98f29

Co-authored-by: Matt Almeida <matt7@hey.com>

Update app/mailers/hackathons/digest_mailer.rb

22c52e1

Co-authored-by: Matt Almeida <matt7@hey.com>

Update app/jobs/hackathons/send_organizer_summaries_job.rb

cf5b9a2

Co-authored-by: Matt Almeida <matt7@hey.com>

sampoder commented Dec 6, 2023

View reviewed changes

app/jobs/hackathons/send_organizer_summaries_job.rb Outdated Show resolved Hide resolved

sampoder added 4 commits December 6, 2023 09:33

Update app/jobs/hackathons/send_organizer_summaries_job.rb

115a937

Merge branch 'main' into organizer-summary

1803fe7

Add a test

8cb41e4

Update organizer_summary_test.rb

41afc2d

northeastprince reviewed Dec 6, 2023

View reviewed changes

northeastprince changed the title ~~Add An Organizer Summary Email~~ Add organizer summary emails Dec 24, 2023

sampoder and others added 2 commits December 24, 2023 15:57

Update test/mailers/hackathons/organizer_summary_test.rb

9dec6ae

Co-authored-by: Matt Almeida <matt7@hey.com>

Merge branch 'main' into organizer-summary

9095300

northeastprince reviewed Dec 25, 2023

View reviewed changes

sampoder and others added 3 commits December 25, 2023 23:24

Update app/jobs/hackathons/digests_delivery_job.rb

90e38fc

Co-authored-by: Matt Almeida <matt7@hey.com>

rename job

8539a84

move the test

9d7c744

sampoder requested a review from northeastprince December 26, 2023 07:28

sampoder and others added 3 commits December 25, 2023 23:29

that was very bad of me

ee65871

run standard and pray

9adae8e

Merge branch 'main' into organizer-summary

9fe0fdc

northeastprince force-pushed the main branch from 8253219 to 2c5c2d6 Compare October 22, 2024 18:50

northeastprince force-pushed the main branch from da4acf5 to e941cda Compare January 10, 2025 15:32

Conversation

sampoder commented Aug 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

garyhtou commented Aug 22, 2023

Uh oh!

sampoder commented Aug 22, 2023 via email

Uh oh!

northeastprince commented Aug 22, 2023

Uh oh!

sampoder commented Aug 22, 2023

Uh oh!

garyhtou left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sampoder commented Aug 22, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

northeastprince Dec 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sampoder Dec 24, 2023

Choose a reason for hiding this comment

Uh oh!

northeastprince Dec 25, 2023

Choose a reason for hiding this comment

Uh oh!

sampoder Dec 26, 2023

Choose a reason for hiding this comment

Uh oh!

northeastprince commented Dec 6, 2023

Uh oh!

Uh oh!

northeastprince Dec 25, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sampoder commented Aug 22, 2023 •

edited

Loading

garyhtou left a comment •

edited

Loading

northeastprince Dec 6, 2023 •

edited

Loading